Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KEDA svg logo with lightning #1079

Merged
merged 7 commits into from
Sep 9, 2020
Merged

Add KEDA svg logo with lightning #1079

merged 7 commits into from
Sep 9, 2020

Conversation

turbaszek
Copy link
Contributor

@turbaszek turbaszek commented Sep 3, 2020 •
edited by tomkerkhove
Loading

The blur around the lighting is similar to the orginal one but not the same:
https://github.com/turbaszek/keda/blob/add-keda-logo-svg/images/keda-word-bolt-blur.svg

The .eps has some weird color - do we need this format?

Signed-off-by: Tomek Urbaszek [email protected]

Checklist

Relates to #650

@zroubalik
Copy link
Member

Looking good!

tomkerkhove
tomkerkhove reviewed Sep 4, 2020
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but:

  • We don't need the EPS so if it's not ideal for you, feel free to leave it out
  • Would be nice to update images/keda-icon.svg as well (for example for docs)

Do you have the bandwidth to pick this up as well?

@turbaszek
Copy link
Contributor Author

turbaszek commented Sep 4, 2020 •
edited
Loading

I will do this over the weekend 👌

Would be nice to update images/keda-icon.svg as well (for example for docs)

Should I update those also in docs repo?

@tomkerkhove
Copy link
Member

That would be awesome! Thanks!

@tomkerkhove
Copy link
Member

In terms of the EPS file, is that to generate the SVG or do you edit it directly?

Sorry, I'm a newbie on this front 😁

@turbaszek
Copy link
Contributor Author

Sorry, I'm a newbie on this front 😁

I'm not an expert too 😄

In terms of the EPS file, is that to generate the SVG or do you edit it directly?

You can edit the SVG directly, the eps is just another file format. I added it because I saw that there are always both .svg and .eps graphics. Probably I just have to figure out the color space as now it's slightly faded.

@tomkerkhove
Copy link
Member

tomkerkhove commented Sep 4, 2020 •
edited
Loading

Oh OK, thanks! Then I think we can removed the EPS indeed.

@turbaszek
Copy link
Contributor Author

turbaszek commented Sep 5, 2020 •
edited
Loading

I've updated the images, please let me know if there's anything to change or we are good to go. Once it's approved I will open PR to docs repo.
https://github.com/turbaszek/keda/blob/add-keda-logo-svg/images/keda-word-bolt.svg
https://github.com/turbaszek/keda/blob/add-keda-logo-svg/images/keda-icon-bolt.svg

@tomkerkhove
Copy link
Member

Is there a reason why we are introducing new files instead of replacing the current ones?

@turbaszek
Copy link
Contributor Author

Is there a reason why we are introducing new files instead of replacing the current ones?

The logo is part of KEDA branding and as I'm not perfectly sure what is the official logo (KEDA with or without the lightning bolt) I don't want to remove any files.

We can use this PR to sort this and I am happy to describe it somewhere so people will be able to find some info in future.

@tomkerkhove
Copy link
Member

Don't hesitate to ask next time!

Sith lightning bolt is the official logo so feel free to replace it.

@tomkerkhove
Copy link
Member

Will do it as part of #1090, thanks for the tip!

I recall having seen a version where the bolt is more explicit by making the bolt itself yellow. What do you think about that?

/cc @zroubalik @jeffhollan @ahmelsayed @anirudhgarg

@turbaszek
Copy link
Contributor Author

turbaszek commented Sep 6, 2020 •
edited
Loading

Screenshot 2020-09-06 at 11 58 43

Here are some ideas that I think make sense. Happy to hear your opinion and eventually adjust to your feedback 👌

@zroubalik
Copy link
Member

I prefer the version 3, version 1 as a backup, in case there would be a problem with the blur.

@turbaszek
Copy link
Contributor Author

I prefer the version 3, version 1 as a backup, in case there would be a problem with the blur.

Make sense to me. I would say that version 3 is general-purpose but the 1 should be used for print and black-white version (required sometimes so I can provide one).

@tomkerkhove
Copy link
Member

I would say #4 but don't have much of a preference.

@zroubalik
Copy link
Member

@tomkerkhove for me, the version 4 is too much leaning towards Azure Functions logo :)

@turbaszek
Copy link
Contributor Author

@tomkerkhove for me, the version 4 is too much leaning towards Azure Functions logo :)

I even wanted to use Azure Function yellow color 😄

@tomkerkhove
Copy link
Member

tomkerkhove commented Sep 7, 2020 •
edited
Loading

@tomkerkhove for me, the version 4 is too much leaning towards Azure Functions logo :)

Heh, fair enough! For me 3 is ok as default logo with 1 for print indeed.

We might even already provide them in color, black and white to help people and we are ready for https://github.com/cncf/artwork/blob/master/examples/sandbox.md#keda-logos.

@zroubalik
Copy link
Member

@turbaszek don't you want to target this to v2 branch? We can then cherry pick relevant changes to the master (soon to be v1 branch).

@turbaszek
Copy link
Contributor Author

turbaszek commented Sep 7, 2020 •
edited
Loading

@zroubalik I'll change the target branch. I should be able to prepare all graphics in the next few days

@turbaszek turbaszek changed the base branch from master to v2 September 7, 2020 17:53
@turbaszek
Add KEDA svg logo with lightning
ec27fdf 
Signed-off-by: Tomek Urbaszek <[email protected]>
@turbaszek
Copy link
Contributor Author

All svg images are here: https://github.com/turbaszek/keda/tree/add-keda-logo-svg/images

Please let me know if everything is ok, then I can prepare png files if we need

@tomkerkhove
Copy link
Member

LGTM, just a few suggestions:

  • keda-word-simple.svg --> keda-word-print.svg
  • keda-icon-simple.svg --> keda-icon-print.svg
  • keda-word.svg --> keda-word-colour.svg
  • keda-icon.svg --> keda-icon-colour.svg

Maybe it's good to move them to a logos folder to put some structure in that folder maybe? WDYT @zroubalik ?

@zroubalik
Copy link
Member

Looking good, images/logos directory is a good idea!

@turbaszek
Move logos to images/logos/
f6f0b2c 
Signed-off-by: Tomek Urbaszek <[email protected]>
@zroubalik
Copy link
Member

Looking good, can we continue with the png images @tomkerkhove @jeffhollan ?

tomkerkhove
tomkerkhove reviewed Sep 8, 2020
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PNGs would be great as @zroubalik suggests and have replacements for these instead of removing them:
image

@zroubalik
Copy link
Member

PNGs would be great as @zroubalik suggests and have replacements for these instead of removing them:
image

Yeah, this change comes with the need of updating the Readme.md and maybe other files, that are consuming these images.

@turbaszek
Copy link
Contributor Author

Yes, I will do the png if we are good with all logo versions. Just wanted to avoid replication of work in case of change requests

@turbaszek
Add .png files
e41e9d9 
Signed-off-by: Tomek Urbaszek <[email protected]>
@turbaszek
Update README
3ee414b 
Signed-off-by: Tomek Urbaszek <[email protected]>
@turbaszek
Copy link
Contributor Author

pngs added, and README looks good I think:
https://github.com/turbaszek/keda/tree/add-keda-logo-svg

@tomkerkhove
Copy link
Member

PNGs would be great as @zroubalik suggests and have replacements for these instead of removing them:
image

Can you re-add these as well please @turbaszek?

@turbaszek
Copy link
Contributor Author

PNGs would be great as @zroubalik suggests and have replacements for these instead of removing them:

image

Can you re-add these as well please @turbaszek?

By re-adding do you mean replacing them with new once with same name or restoring the old one?

@tomkerkhove
Copy link
Member

Replacing them with the new ones indeed!

@turbaszek
Copy link
Contributor Author

I understand the need of having one with a white background, but why should we have two logos with transparent bg? Are those files used somewhere else outside the repo?

@tomkerkhove
Copy link
Member

They are used by us and others indeed. Here is usage on GitHub alone - https://github.com/search?q=keda-logo-transparent.png&type=Code

tomkerkhove
tomkerkhove approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @turbaszek!

zroubalik
zroubalik approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the this!

@tomkerkhove tomkerkhove merged commit b080cf1 into kedacore:v2 Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@jeffhollan jeffhollan Awaiting requested review from jeffhollan

Assignees

@ahmelsayed ahmelsayed

@anirudhgarg anirudhgarg

@jeffhollan jeffhollan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@turbaszek @zroubalik @tomkerkhove @ahmelsayed @anirudhgarg @jeffhollan