HPA creation retry when scaled object validation fails #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmelsayed
approved these changes
Jun 25, 2019
|
Apologies for not reviewing this sooner @Aarthisk! Travel had me occupied. Glad this got sorted! |
No worries Lee! |
patnaikshekhar
pushed a commit
to patnaikshekhar/keda
that referenced
this pull request
Jul 17, 2019
HPA creation retry when scaled object validation fails Former-commit-id: 62e0a06
Aarthisk
pushed a commit
that referenced
this pull request
Aug 12, 2019
HPA creation retry when scaled object validation fails Former-commit-id: 026c3c2
preflightsiren
pushed a commit
to preflightsiren/keda
that referenced
this pull request
Nov 7, 2021
Signed-off-by: Tom Kerkhove <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change keeps track of the HPAs that failed creation and is retried when handleScale gets called.
The metrics adapter also returns errors when the secret/other deployment info cannot be found so HPA does not end up scaling on CPU incorrectly.
#236
#236