Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use safe securityContext as default #2938

Merged
merged 5 commits into from
Apr 28, 2022
Merged

feat: use safe securityContext as default #2938

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b85b0ba
Add securityContext as default
JorTurFer Apr 26, 2022
7f4cfd8
update changelog
JorTurFer Apr 26, 2022
fd7e78e
add podSecurityContext
JorTurFer Apr 26, 2022
aafca52
add note about readOnlyRootFilesystem in metrics server
JorTurFer Apr 26, 2022
e4f19e2
Merge branch 'kedacore:main' into use-non-root
JorTurFer Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ To learn more about our roadmap, we recommend reading [this document](ROADMAP.md
### Improvements

- **General:** Properly handle `restoreToOriginalReplicaCount` if `ScaleTarget` is missing ([#2872](https://github.com/kedacore/keda/issues/2872))
- **General:** Support for running in non-root ([#2933](https://github.com/kedacore/keda/issues/2933))
- **General:** Synchronize HPA annotations from ScaledObject ([#2659](https://github.com/kedacore/keda/pull/2659))
- **General:** Updated HTTPClient to be proxy-aware, if available, from environment variables. ([#2577](https://github.com/kedacore/keda/issues/2577))
- **ActiveMQ Scaler:** Add CorsHeader information to ActiveMQ Scaler ([#2884](https://github.com/kedacore/keda/issues/2884))
Expand Down
11 changes: 11 additions & 0 deletions config/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ spec:
name: keda-operator
name: keda-operator
spec:
securityContext:
runAsUser: 1000
runAsGroup: 1000
fsGroup: 1000
runAsNonRoot: true
serviceAccountName: keda-operator
containers:
- name: keda-operator
Expand Down Expand Up @@ -59,6 +64,12 @@ spec:
value: ""
- name: KEDA_HTTP_DEFAULT_TIMEOUT
value: ""
securityContext:
capabilities:
drop:
- ALL
allowPrivilegeEscalation: false
readOnlyRootFilesystem: true
terminationGracePeriodSeconds: 10
nodeSelector:
kubernetes.io/os: linux
12 changes: 12 additions & 0 deletions config/metrics-server/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ spec:
app: keda-metrics-apiserver
name: keda-metrics-apiserver
spec:
securityContext:
runAsUser: 1000
runAsGroup: 1000
fsGroup: 1000
runAsNonRoot: true
serviceAccountName: keda-operator
containers:
- name: keda-metrics-apiserver
Expand Down Expand Up @@ -61,6 +66,13 @@ spec:
volumeMounts:
- mountPath: /tmp
name: temp-vol
securityContext:
capabilities:
drop:
- ALL
allowPrivilegeEscalation: false
## Metrics server needs to write the self-signed cert so it's not possible set this
# readOnlyRootFilesystem: true
nodeSelector:
kubernetes.io/os: linux
volumes:
Expand Down