Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka Scaler: added support for PKCS #8 private key decryption #3413

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Kafka Scaler: added support for PKCS #8 private key decryption #3413

merged 3 commits into from
Aug 2, 2022

Conversation

tobiaskrause
Copy link
Contributor

@tobiaskrause tobiaskrause commented Jul 21, 2022

Signed-off-by: Tobias Krause [email protected]

Enhanced Kafka TLS configuration to accept a passphrase for a provided PKCS #8 private key.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #3449

@tobiaskrause tobiaskrause marked this pull request as ready for review July 21, 2022 14:28
@tobiaskrause tobiaskrause requested a review from a team as a code owner July 21, 2022 14:28
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, could you please fix the Changelog and open docs PR to update documentation for upcoming (2.8) version?
https://github.com/kedacore/keda-docs/pulls

CHANGELOG.md Outdated Show resolved Hide resolved
@zroubalik
Copy link
Member

zroubalik commented Jul 25, 2022

/run-e2e kafka*
Update: You can check the progress here

@tobiaskrause
Copy link
Contributor Author

PR for doc: kedacore/keda-docs#844

@tobiaskrause tobiaskrause requested a review from zroubalik July 29, 2022 08:16
@zroubalik
Copy link
Member

zroubalik commented Aug 2, 2022

/run-e2e kafka*
Update: You can check the progress here

@zroubalik zroubalik merged commit 81ae8e9 into kedacore:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Kafka Scaler to use encrypted private key
2 participants