Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datadog): ensure that returns the same element that has been checked #3450

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

JorTurFer
Copy link
Member

Signed-off-by: Jorge Turrado [email protected]

If we receive more than 1 point, we are checking that the first one has the correct amount of elements and return an error if not, but after that, we access to the last point, so potentially we are not checking the amount of elements for the latest point if get more than 1 point.

This PR changes the behavior to ensure we access to the same point we have checked

Checklist

Fixes #3448

@JorTurFer JorTurFer requested a review from a team as a code owner July 29, 2022 08:19
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 29, 2022

/run-e2e datadog*
Update: You can check the progress here

@zroubalik zroubalik merged commit 9a34269 into kedacore:main Aug 2, 2022
@JorTurFer JorTurFer deleted the datadog-panic branch January 18, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataDog scaler makes errors in keda-metrics-apiserver and causes keda-operator crashing loop back
2 participants