Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom AWS endpoint #3779

Merged
merged 4 commits into from
Oct 28, 2022
Merged

Support custom AWS endpoint #3779

merged 4 commits into from
Oct 28, 2022

Conversation

yuyuvn
Copy link
Contributor

@yuyuvn yuyuvn commented Oct 27, 2022 •
edited
Loading

  • Allow overriding EndpointUrl for AWS-related scalers
  • DRY AWS client creation

Checklist

  • When introducing a new scaler, I agree with the scaling governance policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #3337

Relates to
kedacore/keda-docs#965

@yuyuvn yuyuvn force-pushed the support-custom-aws-endpoint branch 2 times, most recently from 15993c2 to 4306cfa Compare October 28, 2022 02:05
@yuyuvn yuyuvn force-pushed the support-custom-aws-endpoint branch 3 times, most recently from 37f5264 to 4decb24 Compare October 28, 2022 02:58
@yuyuvn yuyuvn force-pushed the support-custom-aws-endpoint branch from 4decb24 to cf048ce Compare October 28, 2022 03:08
@yuyuvn yuyuvn mentioned this pull request Oct 28, 2022
Merged
1 task
@yuyuvn yuyuvn force-pushed the support-custom-aws-endpoint branch from d1c6dd4 to 2940d08 Compare October 28, 2022 03:31
@yuyuvn yuyuvn force-pushed the support-custom-aws-endpoint branch from 2940d08 to c44d687 Compare October 28, 2022 03:32
@yuyuvn yuyuvn marked this pull request as ready for review October 28, 2022 03:54
@yuyuvn yuyuvn requested a review from a team as a code owner October 28, 2022 03:54
@JorTurFer
Copy link
Member

JorTurFer commented Oct 28, 2022 •
edited by github-actions bot
Loading

/run-e2e aws*
Update: You can check the progress here

JorTurFer
JorTurFer reviewed Oct 28, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement ❤️
Looking good, only small nit with changelog

CHANGELOG.md Outdated Show resolved Hide resolved
@yuyuvn yuyuvn force-pushed the support-custom-aws-endpoint branch from 11eb720 to db3de03 Compare October 28, 2022 07:39
JorTurFer
JorTurFer reviewed Oct 28, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@yuyuvn yuyuvn force-pushed the support-custom-aws-endpoint branch from db3de03 to 6308e5a Compare October 28, 2022 07:43
@JorTurFer
Copy link
Member

JorTurFer commented Oct 28, 2022 •
edited by github-actions bot
Loading

/run-e2e aws*
Update: You can check the progress here

JorTurFer
JorTurFer approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!, thanks for the improvement ❤️

@JorTurFer JorTurFer merged commit 1d6d0f1 into kedacore:main Oct 28, 2022
26tanishabanik pushed a commit to 26tanishabanik/keda that referenced this pull request Nov 1, 2022
@yuyuvn @26tanishabanik
Support custom AWS endpoint (kedacore#3779)
acb0841 
* Support custom AWS endpoint

Signed-off-by: Phan Duc <[email protected]>

* Refactor aws sdk client creation

Signed-off-by: Phan Duc <[email protected]>

* Add changelog for support aws endpoint

Signed-off-by: Phan Duc <[email protected]>

* Move changelog to new section

Signed-off-by: Phan Duc <[email protected]>

Signed-off-by: Phan Duc <[email protected]>
Signed-off-by: 26tanishabanik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow overriding EndpointUrl for AWS-related scalers
2 participants
@yuyuvn @JorTurFer