Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics Server: use vendored OpenAPI definitions #3928

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Metrics Server: use vendored OpenAPI definitions #3928

merged 2 commits into from
Nov 29, 2022

Conversation

olivierlemasle
Copy link
Contributor

@olivierlemasle olivierlemasle commented Nov 29, 2022 •
edited
Loading

custom-metrics-apiserver serves OpenAPI spec by default since version v1.25.0 (cf PR 110).

In KEDA Metrics Server, remove generation of adapter/generated/openapi/zz_generated.openapi.go and use OpenAPI definitions from custom-metrics-apiserver instead.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
    deployment manifests are modified)*
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #3929

@olivierlemasle olivierlemasle requested a review from a team as a code owner November 29, 2022 12:56
@olivierlemasle
Metrics Server: use vendored OpenAPI definitions
66e0497 
custom-metrics-apiserver serves OpenAPI spec by default since
version [v1.25.0] (cf [PR 110]).

[v1.25.0]: https://github.com/kubernetes-sigs/custom-metrics-apiserver/releases/tag/v1.25.0
[PR 110]: kubernetes-sigs/custom-metrics-apiserver#110

In Keda Metrics Server, remove generation of
`adapter/generated/openapi/zz_generated.openapi.go` and use
OpenAPI definitions from custom-metrics-apiserver instead.

Signed-off-by: Olivier Lemasle <[email protected]>
@olivierlemasle olivierlemasle force-pushed the use-custom-metrics-apiserver-openapi-def branch from 134387b to 66e0497 Compare November 29, 2022 13:01
@zroubalik
Copy link
Member

zroubalik commented Nov 29, 2022 •
edited by github-actions bot
Loading

/run-e2e aws*
Update: You can check the progress here

zroubalik
zroubalik approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik enabled auto-merge (squash) November 29, 2022 13:34
@zroubalik zroubalik disabled auto-merge November 29, 2022 13:34
zroubalik
zroubalik reviewed Nov 29, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@olivierlemasle @zroubalik
Update CHANGELOG.md
4cc83db 
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Olivier Lemasle <[email protected]>
@zroubalik
Copy link
Member

zroubalik commented Nov 29, 2022 •
edited by github-actions bot
Loading

/run-e2e internals*
Update: You can check the progress here

@zroubalik zroubalik enabled auto-merge (squash) November 29, 2022 14:22
@zroubalik zroubalik merged commit ce7d013 into kedacore:main Nov 29, 2022
@olivierlemasle olivierlemasle deleted the use-custom-metrics-apiserver-openapi-def branch November 29, 2022 14:55
josephangbc pushed a commit to josephangbc/keda that referenced this pull request Dec 6, 2022
@olivierlemasle @zroubalik @josephangbc
Metrics Server: use vendored OpenAPI definitions (kedacore#3928)
9568a1f 
* Metrics Server: use vendored OpenAPI definitions

custom-metrics-apiserver serves OpenAPI spec by default since
version [v1.25.0] (cf [PR 110]).

[v1.25.0]: https://github.com/kubernetes-sigs/custom-metrics-apiserver/releases/tag/v1.25.0
[PR 110]: kubernetes-sigs/custom-metrics-apiserver#110

In Keda Metrics Server, remove generation of
`adapter/generated/openapi/zz_generated.openapi.go` and use
OpenAPI definitions from custom-metrics-apiserver instead.

Signed-off-by: Olivier Lemasle <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Olivier Lemasle <[email protected]>

Signed-off-by: Olivier Lemasle <[email protected]>
Signed-off-by: Olivier Lemasle <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
josephangbc pushed a commit to josephangbc/keda that referenced this pull request Dec 6, 2022
@olivierlemasle @zroubalik @josephangbc
Metrics Server: use vendored OpenAPI definitions (kedacore#3928)
351cb37 
* Metrics Server: use vendored OpenAPI definitions

custom-metrics-apiserver serves OpenAPI spec by default since
version [v1.25.0] (cf [PR 110]).

[v1.25.0]: https://github.com/kubernetes-sigs/custom-metrics-apiserver/releases/tag/v1.25.0
[PR 110]: kubernetes-sigs/custom-metrics-apiserver#110

In Keda Metrics Server, remove generation of
`adapter/generated/openapi/zz_generated.openapi.go` and use
OpenAPI definitions from custom-metrics-apiserver instead.

Signed-off-by: Olivier Lemasle <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Olivier Lemasle <[email protected]>

Signed-off-by: Olivier Lemasle <[email protected]>
Signed-off-by: Olivier Lemasle <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In KEDA Metrics Server use OpenAPI definitions from custom-metrics-apiserver instead.
2 participants
@olivierlemasle @zroubalik