Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check that ScaledObject name is specified as part of a query for getting metrics #4097

Merged
merged 1 commit into from
Jan 12, 2023
Merged

check that ScaledObject name is specified as part of a query for getting metrics #4097

merged 1 commit into from
Jan 12, 2023

Conversation

zroubalik
Copy link
Member

@zroubalik zroubalik commented Jan 12, 2023 •
edited
Loading

…ing metrics

Signed-off-by: Zbynek Roubalik [email protected]

check that ScaledObject name is specified as part of a query for getting metrics

This doesnt work anymore:

kubectl get --raw "/apis/external.metrics.k8s.io/v1beta1/namespaces/sample-ns/s1-rabbitmq-queueName2"

A selector with ScaledObject's name needs to be specified:

kubectl get --raw "/apis/external.metrics.k8s.io/v1beta1/namespaces/sample-ns/s1-rabbitmq-queueName2?labelSelector=scaledobject.keda.sh%2Fname%3D{ScaledObjectName}"

Checklist

  • Changelog has been updated and is aligned with our changelog requirements
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4088

@zroubalik zroubalik requested a review from a team as a code owner January 12, 2023 12:35
@JorTurFer
Copy link
Member

Don't forget to update docs as well please

@zroubalik
Copy link
Member Author

Don't forget to update docs as well please

kedacore/keda-docs#1037

@zroubalik
Copy link
Member Author

zroubalik commented Jan 12, 2023 •
edited by github-actions bot
Loading

/run-e2e aws*
Update: You can check the progress here

@zroubalik zroubalik enabled auto-merge (squash) January 12, 2023 12:43
@zroubalik zroubalik merged commit 0eca1c6 into kedacore:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error when getting metric values error when getting scalers ScaledObject.keda.sh "" not found
2 participants
@zroubalik @JorTurFer