Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add a warning when KEDA run outside supported k8s versions #4104

Merged
merged 5 commits into from
Jan 17, 2023
Merged

chore: Add a warning when KEDA run outside supported k8s versions #4104

merged 5 commits into from
Jan 17, 2023

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Jan 13, 2023 •
edited
Loading

Signed-off-by: Jorge Turrado [email protected]

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4130

@JorTurFer JorTurFer requested a review from a team as a code owner January 13, 2023 16:07
@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 13, 2023 •
edited by github-actions bot
Loading

/run-e2e internal*
Update: You can check the progress here

tomkerkhove
tomkerkhove approved these changes Jan 13, 2023
View reviewed changes
pkg/util/motd.go Outdated Show resolved Hide resolved
pkg/util/motd.go Outdated Show resolved Hide resolved
pkg/util/motd.go Outdated Show resolved Hide resolved
@JorTurFer @tomkerkhove
Update pkg/util/motd.go
13e34a6 
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
zroubalik
zroubalik reviewed Jan 16, 2023
View reviewed changes
pkg/util/motd.go Outdated Show resolved Hide resolved
@JorTurFer
apply feedback
004609e 
Signed-off-by: Jorge Turrado <[email protected]>
zroubalik
zroubalik reviewed Jan 17, 2023
View reviewed changes
pkg/util/welcome.go Outdated Show resolved Hide resolved
@JorTurFer @zroubalik
apply feedback
a950d18 
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 17, 2023 •
edited by github-actions bot
Loading

/run-e2e internal*
Update: You can check the progress here

zroubalik
zroubalik approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JorTurFer what about changelog? do you want to skip it for this feature?

@JorTurFer
update changelog
e4184c0 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

@JorTurFer what about changelog? do you want to skip it for this feature?

done!

@JorTurFer JorTurFer enabled auto-merge (squash) January 17, 2023 11:48
@JorTurFer JorTurFer merged commit faaa1c6 into kedacore:main Jan 17, 2023
@JorTurFer JorTurFer deleted the add-version-validation branch January 17, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
skip-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a warning when KEDA run outside supported k8s versions
3 participants
@JorTurFer @zroubalik @tomkerkhove