-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests to hashicorpvault handler #5189
Add unit tests to hashicorpvault handler #5189
Conversation
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
d907cdf
to
842d536
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks for the contribution.
Only a nit in Changelog
c0f9f9f
to
1848738
Compare
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
ac52256
to
b13d716
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great job!
/run-e2e hashicorp |
Signed-off-by: dttung2905 <[email protected]> Signed-off-by: Yoon Park <[email protected]>
Signed-off-by: dttung2905 <[email protected]> Signed-off-by: anton.lysina <[email protected]>
Provide a description of what has been changed
Checklist
Fixes #
Relates to #5195