New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate old Azure SDKs into to use `github.com/Azure/azure-sdk-for-go/sdk/azidentity` #5471

Merged

JorTurFer merged 26 commits into kedacore:main from JorTurFer:migrate-eventhub-sdk

Jul 24, 2024

Member

JorTurFer commented Feb 2, 2024 •

edited

Loading

This PR has migrated some old Azure SDKs into the (unified) new one

EventHub: github.com/Azure/azure-event-hubs-go/v3 -> github.com/Azure/azure-sdk-for-go/sdk/messaging/azeventhubs
Blob Storage: github.com/Azure/azure-storage-blob-go -> github.com/Azure/azure-sdk-for-go/sdk/storage/azblob
Storage queues: github.com/Azure/azure-storage-queue-go -> github.com/Azure/azure-sdk-for-go/sdk/storage/azqueue
Azure Key Vault: github.com/Azure/azure-sdk-for-go -> github.com/Azure/azure-sdk-for-go/sdk/security/keyvault/azsecrets
Azure Monitor: github.com/Azure/azure-sdk-for-go -> github.com/Azure/azure-sdk-for-go/sdk/monitor/azquery
Azure Log Analytics: no-sdk -> github.com/Azure/azure-sdk-for-go/sdk/monitor/azquery
Azure Data Explorer: github.com/Azure/azure-kusto-go/kusto uses github.com/Azure/azure-sdk-for-go/sdk/azidentity
Azure Application Insights: Currently it's not supported, I've opened and issue asking for it for migrating it in the future

Additionally to improve the testing experience, I've replaced go test ... | junit.... with gotestsum -> https://github.com/gotestyourself/gotestsum

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update the documentation on (repo) (if applicable) chore: Update docs to reflect changes in eventhub after the SDK migration keda-docs#1313
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5470

Member Author

JorTurFer commented Feb 2, 2024 •

edited by github-actions bot

Loading

/run-e2e azure
Update: You can check the progress here

JorTurFer commented

View reviewed changes

pkg/scalers/azure_data_explorer_scaler_test.go Show resolved Hide resolved

JorTurFer commented

View reviewed changes

pkg/scalers/azure_eventhub_scaler.go Show resolved Hide resolved

JorTurFer commented

View reviewed changes

pkg/scalers/azure_eventhub_scaler.go Show resolved Hide resolved

Member Author

JorTurFer commented Feb 2, 2024 •

edited by github-actions bot

Loading

/run-e2e azure
Update: You can check the progress here

JorTurFer changed the title ~~Migrate Azure EventHub and Azure Storage SDKs~~ Migrate old Azure SDKs into github.com/Azure/azure-sdk-for-go

Member Author

JorTurFer commented Feb 2, 2024 •

edited by github-actions bot

Loading

/run-e2e azure
Update: You can check the progress here

Member Author

JorTurFer commented Feb 2, 2024 •

edited by github-actions bot

Loading

/run-e2e azure
Update: You can check the progress here

Member Author

JorTurFer commented Feb 2, 2024 •

edited by github-actions bot

Loading

/run-e2e azure
Update: You can check the progress here

Member Author

JorTurFer commented Feb 2, 2024 •

edited by github-actions bot

Loading

/run-e2e azure
Update: You can check the progress here

Member Author

JorTurFer commented Feb 6, 2024 •

edited by github-actions bot

Loading

/run-e2e azure
Update: You can check the progress here

JorTurFer changed the title ~~Migrate old Azure SDKs into github.com/Azure/azure-sdk-for-go~~ Migrate old Azure SDKs into to use github.com/Azure/azure-sdk-for-go/sdk/azidentity

Member Author

JorTurFer commented Feb 6, 2024 •

edited by github-actions bot

Loading

/run-e2e azure
Update: You can check the progress here

JorTurFer mentioned this pull request

Support Application Insights querying Azure/azure-sdk-for-go#22355

Open

Member Author

JorTurFer commented Feb 6, 2024 •

edited by github-actions bot

Loading

/run-e2e azure
Update: You can check the progress here

JorTurFer marked this pull request as ready for review

February 13, 2024 21:08

JorTurFer requested a review from a team as a code owner

February 13, 2024 21:08

Member Author

JorTurFer commented Feb 13, 2024 •

edited by github-actions bot

Loading

/run-e2e azure
Update: You can check the progress here

zroubalik approved these changes

View reviewed changes

JorTurFer mentioned this pull request

add core logic to support access token in postgres scaler #5589

Merged

7 tasks

JorTurFer force-pushed the migrate-eventhub-sdk branch from 96bc418 to 40c04ea Compare

March 30, 2024 16:33

Member Author

JorTurFer commented Mar 30, 2024 •

edited by github-actions bot

Loading

/run-e2e azure
Update: You can check the progress here

Member Author

JorTurFer commented Mar 30, 2024 •

edited by github-actions bot

Loading

/run-e2e azure
Update: You can check the progress here

zroubalik reviewed

View reviewed changes

Member

zroubalik left a comment

@JorTurFer what is the status on this please?

Member Author

JorTurFer commented Apr 10, 2024 •

edited

Loading

It's ready to merge from code pov (just pending to rebase main branch). But I think that waiting until v2.14 is released could be a good idea because I'm not 100% sure if I have dropped some AAD-Pod-Identity support and taking into account that v2.15 will remove AAD-Pod-Identity I'm more confident adding this after removing AAD-Pod-Identity.

Member

zroubalik commented Apr 10, 2024 •

edited by JorTurFer

Loading

It's ready to merge from code pov (just pending to rebase main branch). But I think that waiting until v2.14 is released could be a good idea because I'm not 100% sure if I have dropped some AAD-Pod-Identity support and taking into account that v2.15 will remove AAD-Pod-Identity I'm more confident adding this after removing AAD-Pod-Identity.

Okay, sounds good!

tomkerkhove mentioned this pull request

Release: 2.14 #5671

Closed

35 tasks

JorTurFer mentioned this pull request

chore: Remove deprecated AAD-Pod-Identity and AWS-KIAM auths #5782

Merged

4 tasks

Member Author

JorTurFer commented May 26, 2024

time to rebase :)

JorTurFer force-pushed the migrate-eventhub-sdk branch from a81a580 to f39b328 Compare

May 26, 2024 20:35

JorTurFer added 24 commits

July 24, 2024 13:26


          sort

8ba3a9d

Signed-off-by: Jorge Turrado <[email protected]>


          migrate storage SDK

Signed-off-by: Jorge Turrado <[email protected]>


          update changelog and style

3b61dba

Signed-off-by: Jorge Turrado <[email protected]>


          migrate key vault

73388e5

Signed-off-by: Jorge Turrado <[email protected]>


          fix typos

2fc31fd

Signed-off-by: Jorge Turrado <[email protected]>


          Update azure monitor

f06c210

Signed-off-by: Jorge Turrado <[email protected]>


          fix typo

fb75227

Signed-off-by: Jorge Turrado <[email protected]>


          fix e2e tests

c4f32f9

Signed-off-by: Jorge Turrado <[email protected]>


          fix error

b4d2301

Signed-off-by: Jorge Turrado <[email protected]>


          use AZQUERY FOR MONITOR

be9859b

Signed-off-by: Jorge Turrado <[email protected]>


          fix style

23707ca

Signed-off-by: Jorge Turrado <[email protected]>


          use client optiosn

76ae136

Signed-off-by: Jorge Turrado <[email protected]>


          use sdk parsing function

6c63dc9

Signed-off-by: Jorge Turrado <[email protected]>


          migrate log analytics

eec89ea

Signed-off-by: Jorge Turrado <[email protected]>


          update tokens

de93d80

Signed-off-by: Jorge Turrado <[email protected]>


          style

26192dd

Signed-off-by: Jorge Turrado <[email protected]>


          fix typo

a6b1956

Signed-off-by: Jorge Turrado <[email protected]>


          Add missing changes

Signed-off-by: Jorge Turrado <[email protected]>


          bump azure deps

0aefea2

Signed-off-by: Jorge Turrado <[email protected]>


          fix packages

edc11d2

Signed-off-by: Jorge Turrado <[email protected]>


          fix code

65ed041

Signed-off-by: Jorge Turrado <[email protected]>


          fix test

c375985

Signed-off-by: Jorge Turrado <[email protected]>


          fix styles

25b4902

Signed-off-by: Jorge Turrado <[email protected]>


          remove todos

bb57d22

Signed-off-by: Jorge Turrado <[email protected]>

JorTurFer force-pushed the migrate-eventhub-sdk branch from 9a5d414 to bb57d22 Compare

July 24, 2024 11:27

Member Author

JorTurFer commented Jul 24, 2024 •

edited by github-actions bot

Loading

/run-e2e
Update: You can check the progress here

Member Author

JorTurFer commented Jul 24, 2024 •

edited by github-actions bot

Loading

/run-e2e prometheus_metrics_test
Update: You can check the progress here

Member Author

JorTurFer commented Jul 24, 2024 •

edited by github-actions bot

Loading

/run-e2e prometheus_metrics_test
Update: You can check the progress here

JorTurFer merged commit ebc8975 into kedacore:main

18 checks passed

JorTurFer deleted the migrate-eventhub-sdk branch

July 24, 2024 15:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet