fix: issue when GitHub organization contains more than 30 repos #5746

KoblerS · 2024-04-25T11:08:27Z

Fixed issue when GitHub organization contains more than 30 repositories. Scaler will now iterate over the pages according to GitHubs documentation.

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5738

JorTurFer

Nice improvement! Could you include a unit test for this case too?

pkg/scalers/github_runner_scaler.go

KoblerS · 2024-04-28T10:15:39Z

@JorTurFer sure will work on it!

zroubalik

@KoblerS could you please fix the DCO problem?

KoblerS · 2024-05-17T09:02:24Z

@KoblerS could you please fix the DCO problem?

could you please check again. Thanks!

pkg/scalers/github_runner_scaler_test.go

semgrep-app · 2024-05-17T09:03:04Z

Semgrep found 1 context-todo finding:

pkg/scalers/github_runner_scaler_test.go
- L546 - Triage

Consider to use well-defined context

_{Ignore this finding from context-todo.}

Signed-off-by: Simon Kobler <[email protected]>

Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Simon Kobler <[email protected]> Signed-off-by: Simon Kobler <[email protected]>

Signed-off-by: Simon Kobler <[email protected]>

CHANGELOG.md

zroubalik

There are also some problems in the imports:

@@ -2,13 +2,13 @@ package scalers
 
 import (
 	"context"
+	"crypto/rand"
 	"encoding/json"
 	"fmt"
-	"crypto/rand"
+	"html/template"
 	"math/big"
 	"net/http"
 	"net/http/httptest"
-	"html/template"
 	"strings"
 	"testing"
 	"time"

Signed-off-by: Simon Kobler <[email protected]>

zroubalik · 2024-05-17T11:41:42Z

@KoblerS you can see the failed static check output: https://github.com/kedacore/keda/actions/runs/9127598269/job/25098204457?pr=5746

Signed-off-by: Simon Kobler <[email protected]>

KoblerS · 2024-05-17T11:49:32Z

@KoblerS you can see the failed static check output: https://github.com/kedacore/keda/actions/runs/9127598269/job/25098204457?pr=5746

sorry didn't saw it, should be fixed now.

zroubalik · 2024-05-17T12:48:27Z

/run-e2e github
Update: You can check the progress here

KoblerS · 2024-05-20T09:51:46Z

/run-e2e github Update: You can check the progress here

Any updates when this will be merged?

…core#5746) Signed-off-by: Simon Kobler <[email protected]> Signed-off-by: Simon Kobler <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Simon Kobler <[email protected]>

…core#5746) Signed-off-by: Simon Kobler <[email protected]> Signed-off-by: Simon Kobler <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Simon Kobler <[email protected]> Signed-off-by: Jorge Turrado <[email protected]>

* bump golang Signed-off-by: Jorge Turrado <[email protected]> * chore: build with keda-tools:1.22.5 (#5971) * chore: build with keda-tools:1.22.5 to resolve CVE-2024-24790, CVE-2024-24789, and CVE-2024-24791 bump github.com/Azure/azure-sdk-for-go/sdk/azidentity to resolve CVE-2024-35255 Signed-off-by: Paul Yu <[email protected]> * chore: use go install instead of go get and replacing deprecated tools Signed-off-by: Paul Yu <[email protected]> * chore: vendor dependency cleanup Signed-off-by: Paul Yu <[email protected]> * Update missing references to 1.21 Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Paul Yu <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * [BUG-5922] Report failing ScaledJob triggers in status (#5916) Signed-off-by: Josef Karasek <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * [BUG-5656] Annotate Jobs with parent ScaledJob generation (#5876) * Annotate Jobs with parent ScaledJob generation Signed-off-by: Josef Karasek <[email protected]> * fix tests Signed-off-by: Josef Karasek <[email protected]> * fix lint Signed-off-by: Josef Karasek <[email protected]> * fix log message Signed-off-by: Josef Karasek <[email protected]> * update changelog Signed-off-by: Josef Karasek <[email protected]> * update changelog Signed-off-by: Josef Karasek <[email protected]> * update changelog Signed-off-by: Josef Karasek <[email protected]> --------- Signed-off-by: Josef Karasek <[email protected]> Signed-off-by: Zbynek Roubalik <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * fix: `+srv` mongodb url scheme parsing bug (#5773) This commit fixs issue #5760. where OP was facing problem with +srv schema Signed-off-by: Rishikesh Betigeri <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * fix: issue when GitHub organization contains more than 30 repos (#5746) Signed-off-by: Simon Kobler <[email protected]> Signed-off-by: Simon Kobler <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Simon Kobler <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * Fix scaler leak during cache refresh (#5807) Signed-off-by: Guillaume Jacquet <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * Prepare release v2.14.1 Signed-off-by: Jorge Turrado <[email protected]> * add missing change Signed-off-by: Jorge Turrado <[email protected]> * update changelog Signed-off-by: Jorge Turrado <[email protected]> * fix: e2e test regex check tag (#5831) Signed-off-by: Jan Wozniak <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * Validate regex before building image for e2e test (#5783) * added regex pre check before building image Signed-off-by: Yaxhveer <[email protected]> * updated changelog Signed-off-by: Yaxhveer <[email protected]> * refactored Signed-off-by: Yaxhveer <[email protected]> * corrected Signed-off-by: Yaxhveer <[email protected]> * corrected changelog Signed-off-by: Yaxhveer <[email protected]> * updated the workflow Signed-off-by: Yaxhveer <[email protected]> * updated the workflow Signed-off-by: Yaxhveer <[email protected]> --------- Signed-off-by: Yaxhveer <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * fix some pending tasks Signed-off-by: Jorge Turrado <[email protected]> * use AAD-Pod-Identity always Signed-off-by: Jorge Turrado <[email protected]> * use AAD-Pod-Identity always Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Paul Yu <[email protected]> Signed-off-by: Josef Karasek <[email protected]> Signed-off-by: Zbynek Roubalik <[email protected]> Signed-off-by: Rishikesh Betigeri <[email protected]> Signed-off-by: Simon Kobler <[email protected]> Signed-off-by: Simon Kobler <[email protected]> Signed-off-by: Guillaume Jacquet <[email protected]> Signed-off-by: Jan Wozniak <[email protected]> Signed-off-by: Yaxhveer <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> Co-authored-by: Paul Yu <[email protected]> Co-authored-by: Josef Karasek <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]> Co-authored-by: Rishikesh <[email protected]> Co-authored-by: Simon Kobler <[email protected]> Co-authored-by: Simon Kobler <[email protected]> Co-authored-by: Guillaume Jacquet <[email protected]> Co-authored-by: Jan Wozniak <[email protected]> Co-authored-by: Yashveer <[email protected]>

* bump golang Signed-off-by: Jorge Turrado <[email protected]> * chore: build with keda-tools:1.22.5 (kedacore#5971) * chore: build with keda-tools:1.22.5 to resolve CVE-2024-24790, CVE-2024-24789, and CVE-2024-24791 bump github.com/Azure/azure-sdk-for-go/sdk/azidentity to resolve CVE-2024-35255 Signed-off-by: Paul Yu <[email protected]> * chore: use go install instead of go get and replacing deprecated tools Signed-off-by: Paul Yu <[email protected]> * chore: vendor dependency cleanup Signed-off-by: Paul Yu <[email protected]> * Update missing references to 1.21 Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Paul Yu <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * [BUG-5922] Report failing ScaledJob triggers in status (kedacore#5916) Signed-off-by: Josef Karasek <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * [BUG-5656] Annotate Jobs with parent ScaledJob generation (kedacore#5876) * Annotate Jobs with parent ScaledJob generation Signed-off-by: Josef Karasek <[email protected]> * fix tests Signed-off-by: Josef Karasek <[email protected]> * fix lint Signed-off-by: Josef Karasek <[email protected]> * fix log message Signed-off-by: Josef Karasek <[email protected]> * update changelog Signed-off-by: Josef Karasek <[email protected]> * update changelog Signed-off-by: Josef Karasek <[email protected]> * update changelog Signed-off-by: Josef Karasek <[email protected]> --------- Signed-off-by: Josef Karasek <[email protected]> Signed-off-by: Zbynek Roubalik <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * fix: `+srv` mongodb url scheme parsing bug (kedacore#5773) This commit fixs issue kedacore#5760. where OP was facing problem with +srv schema Signed-off-by: Rishikesh Betigeri <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * fix: issue when GitHub organization contains more than 30 repos (kedacore#5746) Signed-off-by: Simon Kobler <[email protected]> Signed-off-by: Simon Kobler <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Simon Kobler <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * Fix scaler leak during cache refresh (kedacore#5807) Signed-off-by: Guillaume Jacquet <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * Prepare release v2.14.1 Signed-off-by: Jorge Turrado <[email protected]> * add missing change Signed-off-by: Jorge Turrado <[email protected]> * update changelog Signed-off-by: Jorge Turrado <[email protected]> * fix: e2e test regex check tag (kedacore#5831) Signed-off-by: Jan Wozniak <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * Validate regex before building image for e2e test (kedacore#5783) * added regex pre check before building image Signed-off-by: Yaxhveer <[email protected]> * updated changelog Signed-off-by: Yaxhveer <[email protected]> * refactored Signed-off-by: Yaxhveer <[email protected]> * corrected Signed-off-by: Yaxhveer <[email protected]> * corrected changelog Signed-off-by: Yaxhveer <[email protected]> * updated the workflow Signed-off-by: Yaxhveer <[email protected]> * updated the workflow Signed-off-by: Yaxhveer <[email protected]> --------- Signed-off-by: Yaxhveer <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * fix some pending tasks Signed-off-by: Jorge Turrado <[email protected]> * use AAD-Pod-Identity always Signed-off-by: Jorge Turrado <[email protected]> * use AAD-Pod-Identity always Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Paul Yu <[email protected]> Signed-off-by: Josef Karasek <[email protected]> Signed-off-by: Zbynek Roubalik <[email protected]> Signed-off-by: Rishikesh Betigeri <[email protected]> Signed-off-by: Simon Kobler <[email protected]> Signed-off-by: Simon Kobler <[email protected]> Signed-off-by: Guillaume Jacquet <[email protected]> Signed-off-by: Jan Wozniak <[email protected]> Signed-off-by: Yaxhveer <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> Co-authored-by: Paul Yu <[email protected]> Co-authored-by: Josef Karasek <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]> Co-authored-by: Rishikesh <[email protected]> Co-authored-by: Simon Kobler <[email protected]> Co-authored-by: Simon Kobler <[email protected]> Co-authored-by: Guillaume Jacquet <[email protected]> Co-authored-by: Jan Wozniak <[email protected]> Co-authored-by: Yashveer <[email protected]>

KoblerS requested a review from a team as a code owner April 25, 2024 11:08

KoblerS force-pushed the feature/fixgithubscaler branch from cb09c29 to e4bebde Compare April 25, 2024 11:10

JorTurFer reviewed Apr 28, 2024

View reviewed changes

pkg/scalers/github_runner_scaler.go Outdated Show resolved Hide resolved

KoblerS force-pushed the feature/fixgithubscaler branch 2 times, most recently from 877071d to bb1d675 Compare May 13, 2024 12:48

KoblerS requested a review from JorTurFer May 13, 2024 12:50

zroubalik reviewed May 17, 2024

View reviewed changes

KoblerS force-pushed the feature/fixgithubscaler branch from bb1d675 to ac9dcd2 Compare May 17, 2024 09:01

KoblerS requested a review from zroubalik May 17, 2024 09:02

semgrep-app bot reviewed May 17, 2024

View reviewed changes

pkg/scalers/github_runner_scaler_test.go Outdated Show resolved Hide resolved

semgrep-app bot reviewed May 17, 2024

View reviewed changes

pkg/scalers/github_runner_scaler_test.go Outdated Show resolved Hide resolved

KoblerS force-pushed the feature/fixgithubscaler branch 6 times, most recently from 41618ff to 72b0d88 Compare May 17, 2024 09:32

Simon Kobler and others added 4 commits May 17, 2024 11:33

fix: issue when GitHub organization contains more than 30 repos

9a24c43

Signed-off-by: Simon Kobler <[email protected]>

Update pkg/scalers/github_runner_scaler.go

bd2f022

Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Simon Kobler <[email protected]> Signed-off-by: Simon Kobler <[email protected]>

fix: unit test

cbf6b1e

Signed-off-by: Simon Kobler <[email protected]>

Fixed PR comments

9adbf62

Signed-off-by: Simon Kobler <[email protected]>

KoblerS force-pushed the feature/fixgithubscaler branch from 72b0d88 to 9adbf62 Compare May 17, 2024 09:33

Merge branch 'main' into feature/fixgithubscaler

8371a8f

Signed-off-by: Simon Kobler <[email protected]>

zroubalik reviewed May 17, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

zroubalik reviewed May 17, 2024

View reviewed changes

Fixed changelog

d50a536

Signed-off-by: Simon Kobler <[email protected]>

KoblerS requested a review from zroubalik May 17, 2024 10:56

Fixed static checks

ee9a242

Signed-off-by: Simon Kobler <[email protected]>

KoblerS force-pushed the feature/fixgithubscaler branch from 0833290 to ee9a242 Compare May 17, 2024 11:47

zroubalik approved these changes May 20, 2024

View reviewed changes

zroubalik merged commit 6aade8f into kedacore:main May 20, 2024
20 checks passed

KoblerS deleted the feature/fixgithubscaler branch May 20, 2024 10:29

JorTurFer mentioned this pull request Jul 30, 2024

Release: v2.14.1 #6002

Closed

23 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: issue when GitHub organization contains more than 30 repos #5746

fix: issue when GitHub organization contains more than 30 repos #5746

KoblerS commented Apr 25, 2024 •

edited by zroubalik

Loading

JorTurFer left a comment

KoblerS commented Apr 28, 2024

zroubalik left a comment

KoblerS commented May 17, 2024

semgrep-app bot commented May 17, 2024

zroubalik left a comment •

edited

Loading

zroubalik commented May 17, 2024

KoblerS commented May 17, 2024

zroubalik commented May 17, 2024 •

edited by github-actions bot

Loading

KoblerS commented May 20, 2024

fix: issue when GitHub organization contains more than 30 repos #5746

fix: issue when GitHub organization contains more than 30 repos #5746

Conversation

KoblerS commented Apr 25, 2024 • edited by zroubalik Loading

Checklist

JorTurFer left a comment

Choose a reason for hiding this comment

KoblerS commented Apr 28, 2024

zroubalik left a comment

Choose a reason for hiding this comment

KoblerS commented May 17, 2024

semgrep-app bot commented May 17, 2024

zroubalik left a comment • edited Loading

Choose a reason for hiding this comment

zroubalik commented May 17, 2024

KoblerS commented May 17, 2024

zroubalik commented May 17, 2024 • edited by github-actions bot Loading

KoblerS commented May 20, 2024

KoblerS commented Apr 25, 2024 •

edited by zroubalik

Loading

zroubalik left a comment •

edited

Loading

zroubalik commented May 17, 2024 •

edited by github-actions bot

Loading