-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor aws dynamodb scaler #5961
Merged
zroubalik
merged 5 commits into
kedacore:main
from
dttung2905:refactor-aws-dynamodb-scaler
Sep 6, 2024
Merged
Refactor aws dynamodb scaler #5961
zroubalik
merged 5 commits into
kedacore:main
from
dttung2905:refactor-aws-dynamodb-scaler
Sep 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dttung2905
commented
Jul 14, 2024
wozniakjan
reviewed
Jul 29, 2024
dttung2905
force-pushed
the
refactor-aws-dynamodb-scaler
branch
from
August 3, 2024 09:30
c57ab6c
to
a9ccda5
Compare
Signed-off-by: dttung2905 <[email protected]>
… too Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
dttung2905
force-pushed
the
refactor-aws-dynamodb-scaler
branch
from
August 10, 2024 16:52
a9ccda5
to
7ffd77b
Compare
dttung2905
changed the title
WIP: Refactor aws dynamodb scaler
Refactor aws dynamodb scaler
Aug 10, 2024
Signed-off-by: dttung2905 <[email protected]>
@wozniakjan @JorTurFer Could you help to review again 🙏 ? |
wozniakjan
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, this is as good as we can get now :)
/run-e2e aws_dynamodb |
zroubalik
approved these changes
Aug 14, 2024
The e2e has passed. @zroubalik @JorTurFer please help me merge when you have time 🙏 |
59 tasks
JorTurFer
pushed a commit
to JorTurFer/keda
that referenced
this pull request
Oct 7, 2024
Signed-off-by: dttung2905 <[email protected]> Signed-off-by: Jorge Turrado <[email protected]>
mpechner-akasa
pushed a commit
to nrichardson-akasa/keda
that referenced
this pull request
Nov 29, 2024
Signed-off-by: dttung2905 <[email protected]> Signed-off-by: michael pechner <[email protected]>
chiragbhatia8
pushed a commit
to chiragbhatia8/keda
that referenced
this pull request
Jan 9, 2025
Signed-off-by: dttung2905 <[email protected]> Signed-off-by: Chirag Bhatia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Checklist
Relates to #5797