Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor aws dynamodb scaler #5961

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

dttung2905
Copy link
Contributor

@dttung2905 dttung2905 commented Jul 14, 2024

Provide a description of what has been changed

Checklist

Relates to #5797

@dttung2905 dttung2905 requested a review from a team as a code owner July 14, 2024 19:46
@dttung2905 dttung2905 force-pushed the refactor-aws-dynamodb-scaler branch from c57ab6c to a9ccda5 Compare August 3, 2024 09:30
@dttung2905 dttung2905 force-pushed the refactor-aws-dynamodb-scaler branch from a9ccda5 to 7ffd77b Compare August 10, 2024 16:52
@dttung2905 dttung2905 changed the title WIP: Refactor aws dynamodb scaler Refactor aws dynamodb scaler Aug 10, 2024
@dttung2905
Copy link
Contributor Author

@wozniakjan @JorTurFer Could you help to review again 🙏 ?

Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this is as good as we can get now :)

@zroubalik
Copy link
Member

zroubalik commented Aug 14, 2024

/run-e2e aws_dynamodb
Update: You can check the progress here

@dttung2905
Copy link
Contributor Author

The e2e has passed. @zroubalik @JorTurFer please help me merge when you have time 🙏

@zroubalik zroubalik merged commit f6358d5 into kedacore:main Sep 6, 2024
21 checks passed
JorTurFer pushed a commit to JorTurFer/keda that referenced this pull request Oct 7, 2024
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: michael pechner <[email protected]>
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: Chirag Bhatia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants