Prevent multiple ScaledObjects managing one HPA #6198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dovics
force-pushed
the
validate-hpa
branch
from
3f2401c to
04dc8c5
Compare
JorTurFer
reviewed
Sep 29, 2024
|
/run-e2e internal |
dovics
force-pushed
the
validate-hpa
branch
from
112e1f5 to
2d26918
Compare
|
Sorry, I missed a line of code when commit, which caused the e2e test in I've rebased main, to solve the other two failed. |
Signed-off-by: wangrushen <[email protected]>
Signed-off-by: wangrushen <[email protected]>
dovics
force-pushed
the
validate-hpa
branch
from
2d26918 to
de0f603
Compare
|
/run-e2e internal Update: You can check the progress here |
|
/run-e2e internal |
JorTurFer
approved these changes
Oct 6, 2024
|
PTAL @zroubalik @wozniakjan |
wozniakjan
reviewed
Oct 21, 2024
Signed-off-by: wangrushen <[email protected]>
|
/run-e2e internals |
wozniakjan
approved these changes
Oct 22, 2024
mpechner-akasa
pushed a commit
to nrichardson-akasa/keda
that referenced
this pull request
Nov 29, 2024
* Prevent multiple ScaledObjects managing one HPA Signed-off-by: wangrushen <[email protected]> * fix: e2e test and mv changelog to improvements Signed-off-by: wangrushen <[email protected]> * check nil for spec.advanced.horizontalPodAutoscalerConfig Signed-off-by: wangrushen <[email protected]> --------- Signed-off-by: wangrushen <[email protected]>
chiragbhatia8
pushed a commit
to chiragbhatia8/keda
that referenced
this pull request
Jan 9, 2025
* Prevent multiple ScaledObjects managing one HPA Signed-off-by: wangrushen <[email protected]> * fix: e2e test and mv changelog to improvements Signed-off-by: wangrushen <[email protected]> * check nil for spec.advanced.horizontalPodAutoscalerConfig Signed-off-by: wangrushen <[email protected]> --------- Signed-off-by: wangrushen <[email protected]> Signed-off-by: Chirag Bhatia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Prevent multiple ScaledObjects managing one HPA
Checklist
Fixes #6130
Relates to #