Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Kubernetes workload scaler config #6226

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Refactor Kubernetes workload scaler config #6226

merged 2 commits into from
Oct 21, 2024

Conversation

rickbrouwer
Copy link
Contributor

@rickbrouwer rickbrouwer commented Oct 9, 2024 •
edited
Loading

  • Refactor the scaler to match the new metadata guidelines.

Checklist

Related: 5797

@rickbrouwer rickbrouwer requested a review from a team as a code owner October 9, 2024 12:16
@rickbrouwer rickbrouwer marked this pull request as draft October 9, 2024 12:16
@rickbrouwer rickbrouwer force-pushed the kubernetes_workload branch 27 times, most recently from 176ef3c to 3151c21 Compare October 10, 2024 06:08
@rickbrouwer rickbrouwer marked this pull request as ready for review October 10, 2024 06:27
@rickbrouwer
Refactor kubernetes workload
e35e9ad 
Signed-off-by: rickbrouwer <[email protected]>
JorTurFer
JorTurFer approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! PTAL @wozniakjan

@JorTurFer
Copy link
Member

JorTurFer commented Oct 16, 2024 •
edited by github-actions bot
Loading

/run-e2e kubernetes
Update: You can check the progress here

wozniakjan
wozniakjan approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@wozniakjan wozniakjan merged commit efe4d7c into kedacore:main Oct 21, 2024
20 checks passed
@wozniakjan wozniakjan mentioned this pull request Oct 21, 2024
Open
59 tasks
rickbrouwer added a commit to rickbrouwer/keda that referenced this pull request Oct 21, 2024
@rickbrouwer
Refactor kubernetes workload (kedacore#6226)
9540764 
Signed-off-by: rickbrouwer <[email protected]>
@rickbrouwer rickbrouwer deleted the kubernetes_workload branch October 21, 2024 12:53
@rickbrouwer rickbrouwer mentioned this pull request Nov 1, 2024
Merged
2 tasks
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
@rickbrouwer @mpechner-akasa
Refactor kubernetes workload (kedacore#6226)
0e31a41 
Signed-off-by: rickbrouwer <[email protected]>
Signed-off-by: michael pechner <[email protected]>
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
@rickbrouwer @chiragbhatia8
Refactor kubernetes workload (kedacore#6226)
b58b9c8 
Signed-off-by: rickbrouwer <[email protected]>
Signed-off-by: Chirag Bhatia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@wozniakjan wozniakjan wozniakjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickbrouwer @JorTurFer @wozniakjan