Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error checking for sqs metrics #6235

Merged
merged 5 commits into from
Nov 3, 2024
Merged

Conversation

robpickerill
Copy link
Contributor

Add error checking for SQS metrics

Checklist

Fixes #6178

@robpickerill robpickerill requested a review from a team as a code owner October 13, 2024 18:14
@SpiritZhou
Copy link
Contributor

SpiritZhou commented Oct 16, 2024

/run-e2e aws_sqs_queue
Update: You can check the progress here

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you update the changelog as well?

Signed-off-by: Rob Pickerill <[email protected]>
@JorTurFer
Copy link
Member

JorTurFer commented Oct 21, 2024

/run-e2e aws_sqs_queue
Update: You can check the progress here

@JorTurFer
Copy link
Member

JorTurFer commented Nov 3, 2024

/run-e2e aws_sqs_queue
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request Nov 3, 2024
28 tasks
@JorTurFer JorTurFer merged commit 9980181 into kedacore:main Nov 3, 2024
17 of 18 checks passed
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
* add error checking for sqs metrics to avoid runtime panics

Signed-off-by: Rob Pickerill <[email protected]>

* update changelog

Signed-off-by: Rob Pickerill <[email protected]>

---------

Signed-off-by: Rob Pickerill <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: michael pechner <[email protected]>
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
* add error checking for sqs metrics to avoid runtime panics

Signed-off-by: Rob Pickerill <[email protected]>

* update changelog

Signed-off-by: Rob Pickerill <[email protected]>

---------

Signed-off-by: Rob Pickerill <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Chirag Bhatia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bad queue length strconv.ParseInt call
3 participants