Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor couchdb scaler #6267

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Refactor couchdb scaler #6267

merged 2 commits into from
Nov 3, 2024

Conversation

rickbrouwer
Copy link
Contributor

  • Refactor the scaler to match the new metadata guidelines.

Checklist

Related: 5797

@rickbrouwer rickbrouwer requested a review from a team as a code owner October 24, 2024 11:03
@rickbrouwer rickbrouwer marked this pull request as draft October 24, 2024 11:03
@rickbrouwer rickbrouwer force-pushed the couch branch 2 times, most recently from 0072175 to 3447c7f Compare October 24, 2024 11:20
@rickbrouwer
Refactor couchdb scaler
319de76 
Signed-off-by: rickbrouwer <[email protected]>
@rickbrouwer rickbrouwer marked this pull request as ready for review October 24, 2024 11:47
@SpiritZhou
Copy link
Contributor

SpiritZhou commented Oct 31, 2024 •
edited by github-actions bot
Loading

/run-e2e couchdb
Update: You can check the progress here

wozniakjan
wozniakjan approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

minor nit below

pkg/scalers/couchdb_scaler.go Outdated Show resolved Hide resolved
@rickbrouwer
Update
0d691a3 
Signed-off-by: rickbrouwer <[email protected]>
@wozniakjan
Copy link
Member

wozniakjan commented Oct 31, 2024 •
edited by github-actions bot
Loading

/run-e2e couchdb
Update: You can check the progress here

@JorTurFer JorTurFer merged commit baec715 into kedacore:main Nov 3, 2024
21 checks passed
@rickbrouwer rickbrouwer deleted the couch branch November 4, 2024 11:09
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
@rickbrouwer @mpechner-akasa
Refactor couchdb scaler (kedacore#6267)
3d9f5f5 
* Refactor couchdb scaler

Signed-off-by: rickbrouwer <[email protected]>

* Update

Signed-off-by: rickbrouwer <[email protected]>

---------

Signed-off-by: rickbrouwer <[email protected]>
Signed-off-by: michael pechner <[email protected]>
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
@rickbrouwer @chiragbhatia8
Refactor couchdb scaler (kedacore#6267)
46b2a92 
* Refactor couchdb scaler

Signed-off-by: rickbrouwer <[email protected]>

* Update

Signed-off-by: rickbrouwer <[email protected]>

---------

Signed-off-by: rickbrouwer <[email protected]>
Signed-off-by: Chirag Bhatia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@wozniakjan wozniakjan wozniakjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickbrouwer @SpiritZhou @wozniakjan @JorTurFer