fix(Redis Streams): Allow default value of 0 for activationLagCount #6481
+2
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created due to a bug found and reported as an issue #6478.
The documentation Redis Streams states that a default of 0 is allowed. In version
v2.15.1
seems that be possible.In
v2.16
a check is applied with a refactoring where the value 0 is not allowed:The code contains the following line:
The second return value (the boolean) determines whether the scaler is active. This becomes
true
ifmetricCount > ActivationLagCount
.Because
ActivationLagCount
cannot be 0, this means that there must be at least 2 messages before scaling is activated. This means that scaling can never be activated on 1 message.Checklist
Fixes #6478