Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For the getScaler method wished to pass the entire scaler object since some parameters are required for new scalers. Currently, only scaledObject name and namespace is passed. #811

Closed
wants to merge 2 commits into from

Conversation

ckuduvalli
Copy link
Contributor

@ckuduvalli ckuduvalli commented May 11, 2020

Provide a description of what has been changed

Checklist

Fixes #

Signed-off-by: Chaitanya Kuduvalli Ramachandra <[email protected]>
@zroubalik
Copy link
Member

@ckuduvalli is there any specific need for this? I don't see the point.

@ckuduvalli
Copy link
Contributor Author

@zroubalik I am writing a new scaler for which I need deployment name, namespace to be passed in to the scaler. Instead of again defining it in the metadata, I wanted to use them. Hence I made this change.

@zroubalik
Copy link
Member

OK, what kind of scaler it is? I think that it is better to include this change into the PR with your scaler, to keep things consistent.

@ckuduvalli
Copy link
Contributor Author

Its a cron scaler. To scale up and scale down the pods at a scheduled time. Do you think its a good use case to check in the cron scaler so that people can use it?

@zroubalik
Copy link
Member

@ckuduvalli interesting. Could you please open an issue first? Describe the scaler you are proposing and open the PR then, thanks! I'll close this one for now.

@zroubalik zroubalik closed this May 11, 2020
@ckuduvalli
Copy link
Contributor Author

@zroubalik Have opened an issue: #812

SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants