This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Figure out GVK mechanism for OpenShift #349
Assignees
Labels
Comments
|
Need to see how kompose is handling it! |
|
@surajssd We specify it manually in TypeObject 💯 |
concaf
added a commit
to concaf/kedge
that referenced
this issue
Oct 17, 2017
This commit adds OpenShift's Apps scheme to support DeploymentConfig. Prior to this commit, the TypeMeta for a DeploymentConfig had to be hard coded, but now it's derived from the generated scheme after addition of the Apps scheme. Fixes kedgeproject#349
concaf
added a commit
to concaf/kedge
that referenced
this issue
Oct 17, 2017
This commit adds OpenShift's Apps scheme to support DeploymentConfig. Prior to this commit, the TypeMeta for a DeploymentConfig had to be hard coded, but now it's derived from the generated scheme after addition of the Apps scheme. The code in Transform() method in pkg/spec/deploymentconfig.go is also refactored to leverage the scheme and be aligned with the code in pkg/spec/deployment.go Fixes kedgeproject#349
concaf
added a commit
to concaf/kedge
that referenced
this issue
Oct 18, 2017
This commit adds OpenShift's Apps scheme to support DeploymentConfig. Prior to this commit, TypeMeta for a DeploymentConfig had to be hard coded, but now it's derived from the generated scheme after addition of the Apps scheme. The code in Transform() method in pkg/spec/deploymentconfig.go is also refactored to leverage the scheme and be aligned with the code in pkg/spec/deployment.go Fixes kedgeproject#349
concaf
added a commit
to concaf/kedge
that referenced
this issue
Oct 23, 2017
This commit adds OpenShift's Apps scheme to support DeploymentConfig. Prior to this commit, TypeMeta for a DeploymentConfig had to be hard coded, but now it's derived from the generated scheme after addition of the Apps scheme. The code in Transform() method in pkg/spec/deploymentconfig.go is also refactored to leverage the scheme and be aligned with the code in pkg/spec/deployment.go Fixes kedgeproject#349
concaf
added a commit
to concaf/kedge
that referenced
this issue
Oct 24, 2017
This commit adds OpenShift's Apps scheme to support DeploymentConfig. Prior to this commit, TypeMeta for a DeploymentConfig had to be hard coded, but now it's derived from the generated scheme after addition of the Apps scheme. The code in Transform() method in pkg/spec/deploymentconfig.go is also refactored to leverage the scheme and be aligned with the code in pkg/spec/deployment.go Fixes kedgeproject#349
cdrage
pushed a commit
to cdrage/kedge
that referenced
this issue
Oct 26, 2017
This commit adds OpenShift's Apps scheme to support DeploymentConfig. Prior to this commit, TypeMeta for a DeploymentConfig had to be hard coded, but now it's derived from the generated scheme after addition of the Apps scheme. The code in Transform() method in pkg/spec/deploymentconfig.go is also refactored to leverage the scheme and be aligned with the code in pkg/spec/deployment.go Fixes kedgeproject#349
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@cdrage pointed out at #315 (comment) that the SetGVK and GetScheme functions only work for Kubernetes, and not for OpenShift. We need to figure out what is the mechanism that OpenShift uses and use that instead of hardcoding the values.
Because hardcoding will not scale once we reach the use case for different Kubernetes/OpenShift versions.
The text was updated successfully, but these errors were encountered: