Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Rename persistentVolumes to something better #51

Closed
surajssd opened this issue Jun 21, 2017 · 2 comments
Closed

Rename persistentVolumes to something better #51

surajssd opened this issue Jun 21, 2017 · 2 comments
Assignees
@concaf
Labels
help wanted kind/refactor priority/high

Comments

@surajssd
Copy link
Member

$subject, right now one of the suggestion is to rename it to:

  • volumeClaims
  • storage

Please comment for any better name.
@kadel
Copy link
Member

kadel commented Jun 21, 2017

+1 for volumeClaims - relatively short and it describes what it is

@pradeepto
Copy link
Member

Examples need to be updated as well.

@concaf concaf self-assigned this Jul 12, 2017
concaf added a commit to concaf/kedge that referenced this issue Jul 12, 2017
@concaf
rename persistentVolumes to volumeClaims
1412cf8 
This commit renames the persistentVolumes field and its JSON tag
in spec.App to volumeClaims.

Every other code change is a result of this refactor.
Docs and examples are also changed to accommodate this change.

Fixes kedgeproject#51
@concaf concaf mentioned this issue Jul 12, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@concaf concaf

Labels
help wanted kind/refactor priority/high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kadel @pradeepto @surajssd @concaf