Added gitlab example #170

surajnarwade · 2017-07-20T05:46:16Z

Added working gitlab example for kedge.

kadel · 2017-07-20T11:15:03Z

examples/gitlab/gitlab.yml

+containers:
+  - image: sameersbn/gitlab:8.16.3
+    volumeMounts:
+    - name: db


data or gitData might be better name here

kadel · 2017-07-20T11:17:39Z

examples/gitlab/gitlab.yml

+      value: "false"
+volumes:
+  - name: db
+    emptyDir: {}


This will lose data if the container is moved to another node.
emptyDir dir shouldn't be used here.

kadel · 2017-07-20T11:18:19Z

examples/gitlab/gitlab.yml

+    emptyDir: {}
+services:
+  - name: gitlab
+    type: NodePort


I would rather use LoadBalancer here.

kadel · 2017-07-20T11:18:58Z

examples/gitlab/postgres.yml

+    - port: 5432
+volumes:
+- name: db
+  emptyDir: {}


This will lose data if the container is moved to another node.
emptyDir dir shouldn't be used here.

kadel · 2017-07-20T11:19:01Z

examples/gitlab/redis.yml

+    - port: 6379
+volumes:
+- name: db
+  emptyDir: {}


This will lose data if the container is moved to another node.
emptyDir dir shouldn't be used here.

kadel · 2017-07-20T11:19:20Z

examples/gitlab/redis.yml

+containers:
+  - image: redis:3.2.4
+    volumeMounts:
+    - name: db


redisData might be better name

kadel · 2017-07-20T11:19:35Z

examples/gitlab/postgres.yml

+containers:
+  - image: sameersbn/postgresql:9.5-3
+    volumeMounts:
+    - name: db


postresqlData might be better name

kadel · 2017-07-20T11:27:46Z

examples/gitlab/postgres.yml

+    - name: db
+      mountPath: /var/lib/postgresql
+    env:
+    - name: DB_USER


variables like DB_USER, DB_PASS and DB_NAME are shared with gitlab container.
It might be better to use ConfigMap for those.

surajssd · 2017-07-24T10:03:00Z

examples/gitlab/README.md

+
+### Example Reference
+
+https://github.com/lwolf/kubernetes-gitlab/tree/master/gitlab


link tag [ ]( )

surajssd · 2017-07-24T10:04:40Z

examples/gitlab/gitlab.yml

@@ -0,0 +1,105 @@
+name: gitlab
+containers:
+  - image: sameersbn/gitlab:8.16.3


nit: this is valid indentation, but we can get rid of two extra spaces like the following:

containers: - image: sameersbn/gitlab:8.16.3 volumeMounts: - name: db mountPath: /home/git/data env: - name: DEBUG value: "false" - name: DB_TYPE value: postgres

I personally prefer indentations as @surajnarwade did it.

surajssd · 2017-07-24T10:14:57Z

@kadel we also decided to segregate the examples directory based on features and on real world examples, so how are we doing that?

Because this is adding to that mix, where all the examples are feature based?

kadel · 2017-07-24T10:44:03Z

@kadel we also decided to segregate the examples directory based on features and on real world examples, so how are we doing that?

Because this is adding to that mix, where all the examples are feature based?

That is separate issue and we should take care of it in another PR

surajssd · 2017-08-02T11:34:45Z

ping @surajnarwade

surajnarwade · 2017-08-02T16:45:32Z

@surajssd @kadel updated PR with suggested changes

cdrage · 2017-08-02T17:02:07Z

Hey @surajnarwade I previously pointed you towards the official GitLab Kubernetes artifacts before you added this example. Why not use those instead? https://gitlab.com/charts/charts.gitlab.io/tree/master/charts

surajnarwade · 2017-08-08T05:53:20Z

@cdrage, same example we have used for kompose. so I picked this one

cdrage · 2017-08-08T14:17:36Z

@surajnarwade I know, but https://gitlab.com/charts/charts.gitlab.io/tree/master/charts is the official one and would gather more adoption. Yes, the one on Kompose needs to be updated too...

surajssd · 2017-08-08T14:39:36Z

@cdrage 👍
Yeah we should follow what is happening in the community!

pradeepto · 2017-08-21T05:31:44Z

@surajnarwade What is the status on this? No update in 13 days.

surajnarwade · 2017-08-24T07:26:41Z

@pradeepto updated with new official gitlab example :)

surajnarwade · 2017-08-24T08:25:35Z

@surajssd @kadel @containscafeine example updated as per official configs,Please review :)

surajssd · 2017-08-31T03:08:49Z

examples/gitlab/gitlab.yml

+    app: gitlab
+replicas: 1
+containers:
+      - name: gitlab


can you adjust indentation to 2 spaces in this section, similar to the way you have done in section of services ?

surajssd · 2017-08-31T03:27:57Z

examples/gitlab/README.md

+### Generating artifacts
+
+```
+$ kedge generate -f gitlab.yml -f redis.yml -f postgres.yml


you can also give

kedge create -f .

dot being current directory so it will take all the YAML files

surajssd · 2017-08-31T03:51:47Z

examples/gitlab/gitlab.yml

+            secretKeyRef:
+              name: gitlab
+              key: redis-password
+        ports:


we can reduce the file size, by removing the ports section, from under pods.

so added following changes

diff --git a/examples/gitlab/gitlab.yml b/examples/gitlab/gitlab.yml index 4164541..fe798e6 100644 --- a/examples/gitlab/gitlab.yml +++ b/examples/gitlab/gitlab.yml @@ -46,17 +46,10 @@ containers: secretKeyRef: name: gitlab key: redis-password - ports: - - name: ssh - containerPort: 22 - - name: http - containerPort: 80 - - name: https - containerPort: 443 livenessProbe: httpGet: path: /help - port: http + port: 80 # This pod takes a very long time to start up. Be cautious when # lowering this value to avoid Pod death during startup. initialDelaySeconds: 200 @@ -67,7 +60,7 @@ containers: readinessProbe: httpGet: path: /help - port: http + port: 80 initialDelaySeconds: 30 timeoutSeconds: 1 periodSeconds: 10 @@ -94,13 +87,13 @@ services: ports: - name: ssh port: 22 - targetPort: ssh + targetPort: 22 - name: http port: 80 - targetPort: http + targetPort: 80 - name: https port: 443 - targetPort: https + targetPort: 443 volumeClaims: - name: gitlab-data diff --git a/examples/gitlab/postgres.yml b/examples/gitlab/postgres.yml index 7e20906..b4ff9ee 100644 --- a/examples/gitlab/postgres.yml +++ b/examples/gitlab/postgres.yml @@ -22,9 +22,6 @@ containers: key: postgres-password - name: POD_IP valueFrom: { fieldRef: { fieldPath: status.podIP } } - ports: - - name: postgresql - containerPort: 5432 livenessProbe: exec: command: @@ -60,7 +57,7 @@ services: ports: - name: postgresql port: 5432 - targetPort: postgresql + targetPort: 5432 volumeClaims: - name: data diff --git a/examples/gitlab/redis.yml b/examples/gitlab/redis.yml index ac9a87c..4465f15 100644 --- a/examples/gitlab/redis.yml +++ b/examples/gitlab/redis.yml @@ -11,9 +11,6 @@ containers: secretKeyRef: name: redis key: redis-password - ports: - - name: redis - containerPort: 6379 livenessProbe: exec: command: @@ -43,7 +40,7 @@ services: ports: - name: redis port: 6379 - targetPort: redis + targetPort: 6379 volumeClaims: - name: redis-data

surajssd · 2017-08-31T03:53:10Z

Apart from those minor changes, the example worked for me!

surajnarwade · 2017-09-05T09:12:15Z

@surajssd @kadel updated with changes :) good to go

surajssd

~~LGTM~~

surajssd · 2017-09-07T05:26:01Z

examples/gitlab/gitlab.yml

+  livenessProbe:
+    httpGet:
+      path: /help
+      port: http


port needs to change to 80

surajssd · 2017-09-07T05:26:46Z

examples/gitlab/gitlab.yml

+  readinessProbe:
+    httpGet:
+      path: /help
+      port: http


also here port needs to be 80

Like it was shown in the diff here: #170 (comment)

Added working gitlab example for kedge.

surajssd

LGTM! WFM now!

surajnarwade force-pushed the examples branch from 731d55e to a3cc197 Compare July 20, 2017 05:47

kadel reviewed Jul 20, 2017

View reviewed changes

kadel added the status/needs-review label Jul 20, 2017

surajssd reviewed Jul 24, 2017

View reviewed changes

concaf removed the status/needs-review label Jul 24, 2017

surajnarwade force-pushed the examples branch from a3cc197 to 3b89c3b Compare August 2, 2017 12:15

surajnarwade force-pushed the examples branch 2 times, most recently from 1ac07ff to 49489a7 Compare August 24, 2017 07:23

surajssd suggested changes Aug 31, 2017

View reviewed changes

surajnarwade force-pushed the examples branch from 49489a7 to be1d87f Compare September 5, 2017 08:29

surajssd approved these changes Sep 7, 2017

View reviewed changes

surajssd suggested changes Sep 7, 2017

View reviewed changes

examples/gitlab/gitlab.yml Outdated

livenessProbe:

httpGet:

path: /help

port: http

Copy link

Member

surajssd Sep 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

port needs to change to 80

surajssd suggested changes Sep 7, 2017

View reviewed changes

Added gitlab example

1495259

Added working gitlab example for kedge.

surajnarwade force-pushed the examples branch from be1d87f to 1495259 Compare September 11, 2017 05:27

surajssd approved these changes Sep 11, 2017

View reviewed changes

surajssd merged commit ff2ca09 into kedgeproject:master Sep 11, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added gitlab example #170

Added gitlab example #170

surajnarwade commented Jul 20, 2017

kadel Jul 20, 2017

kadel Jul 20, 2017

kadel Jul 20, 2017

kadel Jul 20, 2017

kadel Jul 20, 2017

kadel Jul 20, 2017

kadel Jul 20, 2017

kadel Jul 20, 2017

surajssd Jul 24, 2017

surajssd Jul 24, 2017 •

edited

Loading

kadel Jul 24, 2017

surajssd commented Jul 24, 2017

kadel commented Jul 24, 2017

surajssd commented Aug 2, 2017

surajnarwade commented Aug 2, 2017

cdrage commented Aug 2, 2017

surajnarwade commented Aug 8, 2017

cdrage commented Aug 8, 2017 •

edited

Loading

surajssd commented Aug 8, 2017

pradeepto commented Aug 21, 2017

surajnarwade commented Aug 24, 2017

surajnarwade commented Aug 24, 2017

surajssd Aug 31, 2017

surajssd Aug 31, 2017

surajssd Aug 31, 2017

surajssd commented Aug 31, 2017

surajnarwade commented Sep 5, 2017

surajssd left a comment •

edited

Loading

surajssd Sep 7, 2017

surajssd Sep 7, 2017

surajssd Sep 7, 2017

surajssd left a comment


		### Example Reference

		https://github.com/lwolf/kubernetes-gitlab/tree/master/gitlab

Added gitlab example #170

Added gitlab example #170

Conversation

surajnarwade commented Jul 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

surajssd Jul 24, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

surajssd commented Jul 24, 2017

kadel commented Jul 24, 2017

surajssd commented Aug 2, 2017

surajnarwade commented Aug 2, 2017

cdrage commented Aug 2, 2017

surajnarwade commented Aug 8, 2017

cdrage commented Aug 8, 2017 • edited Loading

surajssd commented Aug 8, 2017

pradeepto commented Aug 21, 2017

surajnarwade commented Aug 24, 2017

surajnarwade commented Aug 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

surajssd commented Aug 31, 2017

surajnarwade commented Sep 5, 2017

surajssd left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

surajssd left a comment

Choose a reason for hiding this comment

surajssd Jul 24, 2017 •

edited

Loading

cdrage commented Aug 8, 2017 •

edited

Loading

surajssd left a comment •

edited

Loading