Use kedge defined containers list for init containers #189
Conversation
surajssd
force-pushed
the
change-init-containers
branch
2 times, most recently
from
1bc5197 to
dfb4dfb
Compare
pkg/spec/spec.go
Outdated
| @@ -72,6 +72,7 @@ type ConfigMapMod struct { | |||
|
|
|||
| type PodSpecMod struct { | |||
| Containers []Container `json:"containers,omitempty"` | |||
| InitContainers []Container `json:"initContainers,omitempty"` | |||
There was a problem hiding this comment.
Why this? Isn't initContainers already in PodSpec?
There was a problem hiding this comment.
@kadel but we have things in our Container struct that enhance it, like Health and envFrom that won't show up in InitContainers.
There was a problem hiding this comment.
Ah, I understand now.
Shouldn't we break this PR to two? How is moving populators to separate file related to adding initContainers?
surajssd
force-pushed
the
change-init-containers
branch
from
dfb4dfb to
af0196c
Compare
|
blocked on #190 |
|
@surajssd, thank you for the pull request! We'll ping some people to review your PR. @containscafeine, please review this. |
|
this will probably need rebase after #190 is merged |
We have added some features to containers struct in kedge. Which is being used in the podSpec containers list. But right now init-containers are using container type from upstream. So changed it to use our type of containers list.
surajssd
force-pushed
the
change-init-containers
branch
from
af0196c to
7048ac3
Compare
surajssd
changed the title
|
Is it necessary to add an example in |
I don't think we need an example for this. |
|
@kadel cool thanks! |
|
small change so merging it! |
We have added some features to containers struct in kedge.
Which is being used in the podSpec containers list. But right
now init-containers are using container type from upstream.
So changed it to use our type of containers list.
Fixes #176