This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
check for duplicate volumeClaim definition #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadel
reviewed
Aug 8, 2017
pkg/encoding/validate_test.go
Outdated
|
|
||
| func TestValidateVolumeClaims(t *testing.T) { | ||
|
|
||
| failingTests := [][]spec.VolumeClaim{ |
There was a problem hiding this comment.
It would be nice to have also one passing test
If a volumeClaim with same name is defined now the checks are done, to fail on such a case.
surajssd
force-pushed
the
multiple-pvc-same-name
branch
from
b39e217 to
5de239c
Compare
|
@kadel I have done the update as you asked so PTAL! :-) |
|
@surajssd, thank you for the pull request! We'll ping some people to review your PR. @containscafeine, please review this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a volumeClaim with same name is defined now the checks are done,
to fail on such a case.
Fixes #55