This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Update README within examples #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajssd
suggested changes
Sep 7, 2017
|
I believe that we are supporting single-file and multiple-file. For a real-world example, it seems simpler to have it in one. Enterprise, etc would be good with multiple. Thoughts @kadel @pradeepto @containscafeine ? |
|
@containscafeine ah darn, I'll split them back up to multiple files then. |
cdrage
force-pushed
the
make-examples-one-file-and-detailed
branch
from
cff011d to
f5e4ad1
Compare
|
@containscafeine @surajssd gone ahead and updated the PR with multiple-files rather than a single kedge file. |
|
before merge @cdrage can you update the commit to be according to changes we have made now ? |
cdrage
changed the title
Updates the README with full descriptions as well as change the default file extenssion to .yaml instead of .yml
cdrage
force-pushed
the
make-examples-one-file-and-detailed
branch
from
f5e4ad1 to
9920332
Compare
|
@surajssd done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the examples simpler by making them one file as well as
updating the README's to a full description of how to use said example.