This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
docs: add conventions to consider while development #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits add some docs that are taken from docs that Kubernetes upstream follows. This helps keep the spec of kedge consistent with general conventions that community is trying to follow. Inspired from: [API Conventions](https://github.com/kubernetes/community/blob/2bfe095e4dcd02b4ccd3e21c1f30591ca57518a6/contributors/devel/api-conventions.md)
|
@surajssd Semaphore fails despite virtualbox being ran / correct minikube. Please ignore! It's an e2e issue. |
|
@cdrage PTAL for review and 🎉 tests pass on semaphore! |
|
@cdrage thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits add some docs that are taken from docs that Kubernetes
upstream follows. This helps keep the spec of kedge consistent with
general conventions that community is trying to follow.
Inspired from: API Conventions