Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Issue labeling guide (suggestions welcomed) #284

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Issue labeling guide (suggestions welcomed) #284

merged 1 commit into from
Nov 9, 2017

Conversation

kadel
Copy link
Member

@kadel kadel commented Sep 20, 2017

No description provided.

@kadel kadel force-pushed the label-guide branch 2 times, most recently from c95bb0c to 0527ef3 Compare September 20, 2017 13:58
pradeepto
pradeepto suggested changes Sep 21, 2017
View reviewed changes
Copy link
Member

@pradeepto pradeepto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kadel First pass done. Do note, I am not a native speaker though :)

docs/issue-labeling.md Outdated
size/* labels are for estimating size.
It should be estimation how complicated and time consuming solving this is going to be.

S - simple chage, just few lines (no more than 1 day of work)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/chage/change

docs/issue-labeling.md Outdated
It should be estimation how complicated and time consuming solving this is going to be.

S - simple chage, just few lines (no more than 1 day of work)
M - a little bit more change but still fairly strait forward
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M - considerable change but fair straightforward problem statement

docs/issue-labeling.md Outdated
S - simple chage, just few lines (no more than 1 day of work)
M - a little bit more change but still fairly strait forward
L - a bit more complicated to solve, maybe requiring small refactoring of existing code
XL - complex change, new big feature, requiring big refactoring
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XL - complex change, new big feature, requiring big refactoring, perhaps is an epic and should be broken into smaller tasks.

@surajssd
Copy link
Member

surajssd commented Oct 6, 2017

@kadel have you got some time to address the points from @pradeepto ?

@kadel kadel mentioned this pull request Oct 11, 2017
Closed
@cdrage cdrage force-pushed the master branch 2 times, most recently from 52766ab to 388b72b Compare November 2, 2017 22:59
@kadel kadel force-pushed the label-guide branch 5 times, most recently from f4be01f to 06a071d Compare November 6, 2017 11:36
@kadel kadel changed the title [WIP] Issue labeling guide (suggestions welcomed) Issue labeling guide (suggestions welcomed) Nov 6, 2017
@kadel
Copy link
Member Author

kadel commented Nov 6, 2017

I think that current version is a good start.
We can improve it as it goes and needed.

@cdrage
Copy link
Collaborator

cdrage commented Nov 6, 2017

@tkral Could this be in development.md instead? Since this is "meta" and related more to development. Having a separate doc would end up being in the side-bar of the site.

@kadel
Copy link
Member Author

kadel commented Nov 7, 2017

@tkral Could this be in development.md instead? Since this is "meta" and related more to development. Having a separate doc would end up being in the side-bar of the site.

good point. I will move it to development.md

@kadel
Copy link
Member Author

kadel commented Nov 9, 2017

moved to development.md

@cdrage
Copy link
Collaborator

cdrage commented Nov 9, 2017

LGTM

@cdrage cdrage merged commit b5efedc into kedgeproject:master Nov 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradeepto pradeepto pradeepto requested changes

Assignees
No one assigned
Labels
kind/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kadel @surajssd @cdrage @pradeepto