This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Refactor CMD to reflect cobra defaults #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the cmd / cli folder to use the standard cobra templates (via `cobra init` and `cobra new`. Cleans this up so it's much cleaner. Also changes `pkg/opencomposition.go` to avoid using cobra / viper in it's code (completely separate it from everywhere else).
|
LGTM! Thanks for the clean up! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the cmd / cli folder to use the standard cobra templates (via
cobra initandcobra new. Cleans this up so it's much cleaner.Also changes
pkg/opencomposition.goto avoid using cobra / viper init's code (completely separate it from everywhere else).