This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
fix(spec): add optional tag in struct fields #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`portMappings` was added as an option to ports in services which is option to `ports`, initially `ports` was a compulsory field but with `portMappings` addition, either field can be specified. So adding `+optional` tag to both fields.
|
Is there a way to define that one or the other has to be set? |
|
@kadel could not find any! Even in probes (livenessProbe or readinessProbe) one form of handler is needed, but in code in upstream all of them are |
|
OK, thank you. |
kadel
approved these changes
Oct 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
portMappingswas added as an option to ports in services which isoption to
ports, initiallyportswas a compulsory field but withportMappingsaddition, either field can be specified. So adding+optionaltag to both fields.