This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Remove --distribution flag #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Distribution flag is no longer needed as we specify the controller via the controller flag. For example, using OpenShift: ```yaml controller: deploymentconfig ```
|
This is something for you @containscafeine ;-) |
concaf
approved these changes
Oct 23, 2017
|
🤣 @kadel I cannot have blood on my hands, feel free. |
|
If we are removing this flag how are we gonna detect what distribution are we doing conversion for ? |
Why would you need it? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distribution flag is no longer needed as we specify the controller via
the controller flag.
For example, using OpenShift: