-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
e2e tests failed due to wrong import of the test dependency and since the test starting script was buggy, the tests seemed to pass even if they were failing, now the import has been fixed.
this solves the compilation issue, but tests are still failing
|
and this error is also OK? |
merging this so at least we fix compilation error |
@kadel yep those are okay the connection is refused until the healthchecks pass, and the curl is tried until certain timeout, after that the test is declared as failed. |
Then those errors shouldn't be displayed, as they are not actually errors. The output from e2e is a bit confusing, as it includes a lot of information that doesn't say anything useful :-( |
@kadel the decision to run tests in verbose mode was made here #77 (comment) I am of opinion to run tests in normal mode though! |
I have the same opinion. If tests are running successfully, we don't need any output. just OK, or PASS is ok. Only if the test fails then it should display as much info as it can. |
e2e tests failed due to wrong import of the test dependency and
since the test starting script was buggy, the tests seemed to pass
even if they were failing, now the import has been fixed.
Fixes #371