Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Update examples to reflect shortcuts #435

Merged
merged 1 commit into from
Nov 23, 2017

Conversation

cdrage
Copy link
Collaborator

@cdrage cdrage commented Nov 7, 2017

Updates all the examples to reflect the "kedge" keys that enable
reducing the Kubernetes artifact file length. Such as portMappings and
health.

httpGet:
path: /help
port: 80
initialDelaySeconds: 200
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readiness and liveliness probes originally had different initalDelaySeconds.

But I suppose that for purpose of the demo it is ok to consolidate (maybe)
What @surajnarwade thinks about this ?

@surajssd
Copy link
Member

We did not want to have the shortcuts for health, because they were taken from the upstream so we might want to consider before making those changes. We will only use shortcuts like health when all the values are same!

@cdrage
Copy link
Collaborator Author

cdrage commented Nov 13, 2017

@surajssd Then what's the point of health when both readiness and liveness probe's often have different values? 👎 Sure it's a good shortcut and cuts down the file-length, but I've rarely seen both readiness and liveness probes being the same values. Maybe this is good for a different discussion!

@surajssd
Copy link
Member

@cdrage in most cases it is same, but not in this particular case!

@cdrage
Copy link
Collaborator Author

cdrage commented Nov 14, 2017

@surajssd More.. both examples are different here. I guess I'll change it back!

@cdrage cdrage force-pushed the update-examples-health branch from d15f99c to 39c5fc0 Compare November 14, 2017 12:24
@cdrage
Copy link
Collaborator Author

cdrage commented Nov 14, 2017

Examples fixed, HOWEVER. We are blocked on #438 . Got to wait until #438 is fixed before this will work.

Updates all the examples to reflect the "kedge" keys that enable
reducing the Kubernetes artifact file length. Such as portMappings and
health.
@cdrage cdrage force-pushed the update-examples-health branch from 39c5fc0 to f512dbe Compare November 22, 2017 17:06
@cdrage
Copy link
Collaborator Author

cdrage commented Nov 22, 2017

Re-based after port mappings has been merged, integration + unit tests pass.

Ready for review 💯 @surajssd @kadel

Copy link
Member

@surajssd surajssd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cdrage
Copy link
Collaborator Author

cdrage commented Nov 23, 2017

Since we've released #486 I'm going to go ahead with the examples merge! 👍

@cdrage cdrage merged commit 1d4ac68 into kedgeproject:master Nov 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants