-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
examples/gitlab/gitlab.yml
Outdated
httpGet: | ||
path: /help | ||
port: 80 | ||
initialDelaySeconds: 200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readiness and liveliness probes originally had different initalDelaySeconds
.
But I suppose that for purpose of the demo it is ok to consolidate (maybe)
What @surajnarwade thinks about this ?
We did not want to have the shortcuts for health, because they were taken from the upstream so we might want to consider before making those changes. We will only use shortcuts like |
@surajssd Then what's the point of |
@cdrage in most cases it is same, but not in this particular case! |
@surajssd More.. both examples are different here. I guess I'll change it back! |
d15f99c
to
39c5fc0
Compare
Updates all the examples to reflect the "kedge" keys that enable reducing the Kubernetes artifact file length. Such as portMappings and health.
39c5fc0
to
f512dbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Since we've released #486 I'm going to go ahead with the examples merge! 👍 |
Updates all the examples to reflect the "kedge" keys that enable
reducing the Kubernetes artifact file length. Such as portMappings and
health.