This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
docs(dev guide): add instructions to update vendored openshift #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
suggested changes
Nov 16, 2017
docs/development.md
Outdated
| ```bash | ||
| glide cc | ||
| ``` | ||
| This step is necessary if not done glide will pick up old data from it's cache. |
docs/development.md
Outdated
|
|
||
| 1. Update the OpenShift version in `scripts/vendor-openshift.sh`. | ||
|
|
||
| 2. Clear cache |
There was a problem hiding this comment.
Just make this more descriptive so you don't have to add the extra sentence below.
Clear the cache to prevent glide from using previous data
docs/development.md
Outdated
| @@ -130,6 +130,30 @@ git add glide.yaml glide.lock vendor | |||
| git commit | |||
| ``` | |||
|
|
|||
| #### Updating OpenShift | |||
|
|
|||
| 1. Update the OpenShift version in `scripts/vendor-openshift.sh`. | |||
There was a problem hiding this comment.
Include link to the file (github link?)
Perhaps
Update OPENSHIFT_VERSION within [`scripts/vendor-openshift.sh`](https://github.com/kedgeproject/kedge/blob/master/scripts/vendor-openshift.sh)
docs/development.md
Outdated
| ``` | ||
| This step is necessary if not done glide will pick up old data from it's cache. | ||
|
|
||
| 3. Get new and updated dependencies |
There was a problem hiding this comment.
Retrieve new and updated dependencies
| 4. Commit updated glide files and vendor | ||
|
|
||
| ```bash | ||
| git add glide.yaml glide.lock vendor |
There was a problem hiding this comment.
Can't you just do git add . ? No need to specify exact files
There was a problem hiding this comment.
Exact files specified so that this vendor update goes in a separate commit and the code change if any goes in separate commit!
There was a problem hiding this comment.
Okay, seems reasonable to me!
surajssd
force-pushed
the
update-vendor-instructions
branch
from
a8351ba to
3640c31
Compare
cdrage
approved these changes
Nov 17, 2017
|
LGTM merge when ready |
|
Thanks @cdrage! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.