This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
validate container names #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajssd
force-pushed
the
multiple-container-names
branch
from
0293e10 to
bc8d6aa
Compare
kadel
suggested changes
Jun 21, 2017
| // if not fail giving error | ||
| for cn, c := range app.PodSpec.Containers { | ||
| if c.Name == "" { | ||
| return nil, errors.New(fmt.Sprintf("app %q: container name not defined for app.containers[%d]", app.Name, cn)) |
There was a problem hiding this comment.
its better to use fmt.Errorf("app %q: container name not defined for app.containers[%d]", app.Name, cn)
instead of combination errors.New(fmt.Sprintf(... It does the same thing, and its much more readable
There was a problem hiding this comment.
@kadel we are using the pattern of wraping errors everywhere, isn't it?
There was a problem hiding this comment.
yes, but this is not about wraping errors, it'ts just that errors.New doest exactly the same thing, but you are calling only one function
If multiple containers are specified we check if the name field for each container is given or not
surajssd
force-pushed
the
multiple-container-names
branch
from
bc8d6aa to
c6e7565
Compare
kadel
approved these changes
Jun 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple containers are specified we check if the name field for each container is given or not.
Fixes #32