Using float value > 0 as the activation criterium #47
Conversation
Signed-off-by: Jirka Kremser <[email protected]>
| res := &externalscaler.GetMetricsResponse{ | ||
| MetricValues: []*externalscaler.MetricValue{ | ||
| { | ||
| MetricName: metricRequest.GetMetricName(), | ||
| MetricValue: int64(math.Round(value)), | ||
| MetricValue: int64(math.Ceil(value)), |
There was a problem hiding this comment.
side note: we should fix the external scaler interface, KEDA internal scalers support float here, eg: https://github.com/kedacore/keda/blob/cd595a1c3fd56ca17806ff8331a1cd6ed7549e12/pkg/scalers/activemq_scaler.go#L208
There was a problem hiding this comment.
yep, I wanted to ask about that.. so I can make a pr to the proto as well and once it's there, throw away the float -> int function. I used the ceil instead of Round here to make the scale out use case faster
There was a problem hiding this comment.
If you ment kedacore proto, then yeah. But we should also maintain a backwards compatibility somehow, there are existing external scalers that rely on int param there.
There was a problem hiding this comment.
pr upstream - kedacore/keda#6482
No description provided.