-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added publishing tools #3
Conversation
argument or environmental variable which will update both at the same time e.g.: | ||
|
||
```bash | ||
make version VIZ_VERSION=1.0.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to make it run the same as the NPM command, like make version 1.0.5
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. It appears to be a Make limitation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok no worries, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this is neater but you can do something like this too:
export VIZ_VERSION=1.0.5
make version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd get a ✅ from a Python dev before merging
* Automating Release process (#1) * v6.3.6 * Revert "v6.3.6" This reverts commit 5ffe696. * v6.3.5 * testing release workflow-1 * testing release workflow-1 * testing release workflow-1 * Release/testing (#2) * v6.3.6 * Revert "v6.3.6" This reverts commit 5ffe696. * v6.3.5 * testing release workflow-1 * testing release workflow-1 * testing release workflow-1 * testing release workflow-1 * Release/testing (#3) * v6.3.6 * Revert "v6.3.6" This reverts commit 5ffe696. * v6.3.5 * testing release workflow-1 * testing release workflow-1 * testing release workflow-1 * testing release workflow-1 * final draft * update workflow config * Revert "Release/testing (#3)" This reverts commit d54180d. * merging main * reverting changes to main * final change to extract release notes * update contributing guide * modify Release doc * modify release guide and add release branch condition * fix PR comments
Notice
I acknowledge and agree that, by checking this box and clicking “Submit Pull Request”:
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
Motivation and Context
To ease release and publishing process.
How has this been tested?
Manually.
How to use
makefile version
VIZ_VERSION
argument as an environmental variable or argument to the above command.Checklist
RELEASE.md
fileType
label to the PR