You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
🥳 FUN TICKET 🥳 Prerequisites: #1470 and #1469. Based off point 2 of #1464
add rich as a core kedro dependency
add the following handler to framework-side logging.yml
rich:
class: rich.logging.RichHandlers
for any loggers that have console listed under the handlers (probably just root), swap console for rich. Leave the console handlers still defined though
make the same change in the project-side logging.yml (+ starters + e2e test)
there should be no need to set level but check this works right (should show messages >= INFO for kedro, >= WARNING for all other loggers)
generally play around with the options - probably the defaults are suitable for the most part but feel free to be creative, see what looks nice with a kedro run, e.g. do we want to set log_time_format: [%X]?
don't set markup: True. Since we're modifying the root logger that would be too risky as other libraries might not be rich-aware and use [] that breaks stuff. We'll do markup for kedro logging in another ticket
test thoroughly to check that kedro run looks nice and what happens if you emit log messages from outside the kedro logger
test what happens if you do session.run in ipython and jupyter
It will be - I just added more detail to the ticket to explain this. I'm very keen on using markup=True where we can in a follow-up ticket, just don't want to apply it to all loggers in the first step here.
🥳 FUN TICKET 🥳 Prerequisites: #1470 and #1469. Based off point 2 of #1464
rich
as a core kedro dependencyconsole
listed under thehandlers
(probably justroot
), swapconsole
forrich
. Leave theconsole
handlers still defined thoughrich
- read https://rich.readthedocs.io/en/stable/reference/logging.html and https://rich.readthedocs.io/en/stable/logging.html to see what these arelevel
but check this works right (should show messages >= INFO for kedro, >= WARNING for all other loggers)kedro run
, e.g. do we want to setlog_time_format: [%X]
?markup: True
. Since we're modifying theroot
logger that would be too risky as other libraries might not be rich-aware and use[]
that breaks stuff. We'll domarkup
for kedro logging in another ticketkedro run
looks nice and what happens if you emit log messages from outside the kedro loggersession.run
in ipython and jupyterrich
toconsole
by modifying their project-side logging.yml As in Write documentation on how to make a custom logging.yml in your project #1474, this should be as easy as possibleThe text was updated successfully, but these errors were encountered: