You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
🥳 FUN TICKET 🥳 Prerequisites: #1512. Based off point 4 of #1464
Understand what exactly is the difference between setting rich_tracebacks: True on our rich logging handler vs. rich.traceback.install - it would probably be neatest if we can achieve everything we want to just by altering the log handler and not running rich.traceback.install
probably the defaults are good for our use, but feel free to change any if there are better values for our use
in particular, suppress for click and/or kedro looks like the most powerful option to add
overall we want exceptions to be clear to the user exactly what the problem is so that they can debug things easily without having to wade through long tracebacks of unrelated framework errors
Assuming we're going for the log handler route, add the right options to all the places where rich logging handler is defined (framework logging.yml + project-side logging.yml + starters + e2e test)
Test thoroughly to check that kedro run works nicely when there are exceptions coming from different places (e.g. in a node function, in some external libary, in the kedro framework, a KedroCLIError)
Test similarly to see what happens if you do session.run in ipython and jupyter
The text was updated successfully, but these errors were encountered:
For the record, this is the breaking thing I mentioned. The path is usually a clickable path that will jump to the line of code which raises the Error.
With these 2 lines, the path becomes not clickable. It will be a good idea to test on VS code as well.
from rich.traceback import install
install(show_locals=True)
🥳 FUN TICKET 🥳 Prerequisites: #1512. Based off point 4 of #1464
rich_tracebacks: True
on ourrich
logging handler vs.rich.traceback.install
- it would probably be neatest if we can achieve everything we want to just by altering the log handler and not runningrich.traceback.install
rich.traceback.install
depending on which we are usingsuppress
forclick
and/orkedro
looks like the most powerful option to addrich
logging handler is defined (framework logging.yml + project-side logging.yml + starters + e2e test)kedro run
works nicely when there are exceptions coming from different places (e.g. in a node function, in some external libary, in the kedro framework, aKedroCLIError
)session.run
in ipython and jupyterThe text was updated successfully, but these errors were encountered: