Make interface additions for #203 while maintaining minor release compatibility. #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to mention, the workflow I'm suggesting here is that this change goes to vnext_minor, and once we're ready to package a release we grab what we want from vnext_minor and/or vnext_major along with patch releases in master. That way minor revision changes won't preclude a patch release if the patch is made after a minor version change, and same for major revision changes. |
|
Just noticed NSURLSession uses a naming pattern of completionHandler:, so I'm going to standardize everything with that to try to follow conventions of the framework. |
masojus
approved these changes
Apr 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates a few selectors on KeenClient that shouldn't be there. They were exposed only for testing. Also, don't use those methods for testing, use the full async method that uses the queue.
Rename a few methods to have more Obj-C style names, deprecating the old methods. They're still there so this can go in a minor release. All deprecated methods should be cleaned out when we do a major revision.