Make timestamp include milliseconds, report upload errors, and include prior attempts count in uploaded events
#239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…load errors to clients. Also add a keen.prior_attempts property to events so it's obvious if an event was upload because of a retry. This change also removes a bunch of redundant tests, adds a few new constants where appropriate, provides better names for some constants, uses the more concise indexing operator [] for dictionaries and arrays where code has been modified, and adds new error codes for upload related errors.
1 similar comment
2 similar comments
|
Closing this as it's a WIP and further investigation is pending. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
uploadWithCompletionHandler:(void(^)(NSError *), which reports upload errors to clients.Also add a
keen.prior_attemptsproperty to events so it's obvious if an event was upload because of a retry.The
keen.timestampproperty now also includes millisecond values.This change also removes a bunch of redundant tests, adds a few new constants where appropriate, provides better names for some constants, uses the more concise indexing operator [] for dictionaries and arrays where code has been modified, and adds new error codes for upload related errors.
Fixes #237