Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename --goerli flag to --testnet flag, remove --mainnet flag #3579

Closed
4 tasks done
pdyraga opened this issue May 22, 2023 · 1 comment
Closed
4 tasks done

Rename --goerli flag to --testnet flag, remove --mainnet flag #3579

pdyraga opened this issue May 22, 2023 · 1 comment
Assignees
@nkuba
Labels
📟 client
Milestone
v2.0.0-m4

Comments

@pdyraga
Copy link
Member

pdyraga commented May 22, 2023 •
edited by nkuba
Loading

See this discussion.

As someone not that familiar with the client code, I would be confused about --goerli flag. This flag clearly connects the client to Goerli Ethereum testnet, but how would I select the Bitcoin testnet?

Eventually, we should have one client binary where I select --testnet for Sepolia (will replace Goerli) + Bitcoin testnet, and --developer for local Ethereum and regtest. Mainnet Ethereum + mainnet Bitcoin would be the default one. Renaming --goerli to --testnet is the first step. The next step is figuring out the build process (out of scope currently) so that we build one client binary instead of testnet-specific and mainnet-specific versions (out of scope of this PR).

To be done when working on this issue:
@pdyraga pdyraga mentioned this issue May 22, 2023
Merged
@nkuba nkuba self-assigned this May 23, 2023
nkuba added a commit that referenced this issue May 23, 2023
@nkuba
Replace flag --goerli with --testnet
085beca 
We define a general --testnet flag for the client that will be used to
resolve ethereum and bitcoin networks for the client run.
After we added bitcoin support the --goerli flag was confusing to use,
at it relates to ethereum only.

To run the client agains mainet networks no flag is required. To
maintain backward compatibility the --mainnet flag remained but was
marked as deprecated. It will be removed in the future.

Refs: #3579
@nkuba nkuba mentioned this issue May 23, 2023
Merged
nkuba added a commit that referenced this issue May 23, 2023
@nkuba
Replace flag --goerli with --testnet
859b2b7 
We define a general `--testnet` flag for the client that replaces
the `--goerli` flag.
The flag determines the threshold network against which the client
runs and is used to resolve Ethereum and Bitcoin networks.

After we added Bitcoin support the `--goerli` flag was confusing
to use, as it relates to Ethereum only.

To run the client against the mainnet network no flag is required.
To maintain backward compatibility the `--mainnet` flag remained
available but it was marked as deprecated. We will remove the
`--mainnet` flag in the future.

Refs: #3579
lukasz-zimnoch added a commit that referenced this issue May 24, 2023
@lukasz-zimnoch
Replace flag --goerli with --testnet (#3583)
c8c3cb0 
We define a general `--testnet` flag for the client that replaces the
`--goerli` flag.
The flag determines the threshold network against which the client runs
and is used to resolve Ethereum and Bitcoin networks.

After we added Bitcoin support the `--goerli` flag was confusing to use,
as it relates to Ethereum only.

To run the client against the mainnet network no flag is required. To
maintain backward compatibility the `--mainnet` flag remained available
but it was marked as deprecated. We will remove the `--mainnet` flag in
the future.

Refs: #3579
@nkuba
Copy link
Member

nkuba commented May 24, 2023 •
edited
Loading

  • Remove --mainnet flag

We decided to mark the flag deprecated for backward compatibility and remove it in the future. Please see #3583

nkuba added a commit that referenced this issue Jun 5, 2023
@nkuba
Set --testnet flags for keep-clients in keep-test
bbfee80 
The flag was renamed from `--goerli` to `--testnet`.

Refs: #3579
@nkuba nkuba closed this as completed Jun 6, 2023
@pdyraga pdyraga added this to the v2.0.0-m4 milestone Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkuba nkuba

Labels
📟 client
Projects
None yet
Milestone
v2.0.0-m4
Development

No branches or pull requests
2 participants
@pdyraga @nkuba