Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mainnet Electrum Servers Monitoring #3594

Closed
1 task done
nkuba opened this issue May 31, 2023 · 1 comment · Fixed by #3599
Closed
1 task done

Mainnet Electrum Servers Monitoring #3594

nkuba opened this issue May 31, 2023 · 1 comment · Fixed by #3599
Assignees
@nkuba
Labels
📟 client
Milestone
v2.0.0-m4

Comments

@nkuba
Copy link
Member

nkuba commented May 31, 2023 •
edited by pdyraga
Loading

Currently, integration tests in the client validate integration with testnet electrum servers (see: pkg/bitcoin/electrum/electrum_integration_test.go).
We need a way to validate the mainnet servers we embedded in the client:

  • support all the functions the client uses,
  • are up-to-date with the chain tip.

We need this verification to be executed periodically and alert us in case of discovered problems.

Pull Requests
Preview Give feedback
  1. Electrum integration tests for mainnet servers #3599
    📟 client
    nkuba
This was referenced May 31, 2023
Merged
Merged
@pdyraga
Copy link
Member

pdyraga commented Jun 7, 2023

We agreed with @nkuba to close this issue when #3599 is merged. Electrum connectivity monitoring will be addressed in #3608.

@pdyraga pdyraga added this to the v2.0.0-m4 milestone Jun 7, 2023
@nkuba nkuba mentioned this issue Jun 8, 2023
Merged
pdyraga added a commit that referenced this issue Jun 15, 2023
@pdyraga
Electrum integration tests for mainnet servers (#3599)
78da87c 
In this PR we implement support for mainnet servers in the electrum
client integration tests.

We also include the embedded electrum servers in the verification.

To run the tests execute:
```sh
go test -v -tags=integration ./pkg/bitcoin/electrum -count=1
```

Closes: #3594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkuba nkuba

Labels
📟 client
Projects
None yet
Milestone
v2.0.0-m4
Development

Successfully merging a pull request may close this issue.

Electrum integration tests for mainnet servers keep-network/keep-core
2 participants
@pdyraga @nkuba