Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Declare/Deploy Tx 🚀 #89

Merged
merged 16 commits into from
Mar 27, 2023
Merged

Declare/Deploy Tx 🚀 #89

merged 16 commits into from
Mar 27, 2023

Conversation

EvolveArt
Copy link
Collaborator

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

Issue Number: #77 #78

Does this introduce a breaking change?

  • Yes
  • No

Other information

@EvolveArt EvolveArt marked this pull request as ready for review March 26, 2023 15:47
AbdelStark
AbdelStark reviewed Mar 26, 2023
View reviewed changes
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments. Will do a more complete review tomorrow

Cargo.toml Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
AbdelStark
AbdelStark suggested changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Show resolved Hide resolved
crates/pallets/starknet/src/tests.rs Show resolved Hide resolved
crates/primitives/starknet/src/transaction/mod.rs Outdated Show resolved Hide resolved
crates/primitives/starknet/src/transaction/mod.rs Outdated Show resolved Hide resolved
@0xLucqs 0xLucqs self-requested a review March 27, 2023 08:59
0xLucqs
0xLucqs suggested changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@0xLucqs 0xLucqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format and remove all commented code

crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/tests.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/tests.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/tests.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/types.rs Outdated Show resolved Hide resolved
crates/primitives/starknet/src/execution/mod.rs Outdated Show resolved Hide resolved
@EvolveArt EvolveArt requested review from 0xLucqs and AbdelStark and removed request for 0xLucqs March 27, 2023 13:26
AbdelStark
AbdelStark approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@EvolveArt EvolveArt requested a review from 0xLucqs March 27, 2023 14:13
@0xLucqs 0xLucqs merged commit 096dfc2 into keep-starknet-strange:main Mar 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@0xLucqs 0xLucqs 0xLucqs approved these changes

@AbdelStark AbdelStark AbdelStark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EvolveArt @AbdelStark @0xLucqs