-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear credentials when the screen is locked #358
Conversation
This did not work for me. I went to a page that had credentials, they were loaded into the drop-down selection. I locked my computer and unlocked. When I returned KPXC was locked and the browser icon showed the locked icon, but the credentials were still loaded. Why not call the clear credentials function when the icon is changed to the lock symbol? P.S. - I am on Chrome / Win10 |
1cbaa34
to
e1aa58b
Compare
@droidmonkey Fixed. Check if it happens anymore. |
While testing this (merged into PR #387), I ran into the following scenario (FF65, Windows 10):
In my tries, the credentials were not cleared and still suggested in the autocomplete-dialog. On a website without frames, the credentials were cleared after step 5. |
@whisdol Thanks! I'll check what causes this. |
This fix works for me, credentials are now (also) cleared after closing KeePassXC. |
54b27b1
to
9301c3b
Compare
Fix for clearing the credentials when locking the screen.
Document visibility is hidden when the screen is locked. That kind of situation was not handled in the extension. The database hashes are updated only when the current document/page is visible. Now, when the document is hidden, all credentials are cleared just in case.
Fixes #357.