Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear credentials when the screen is locked #358

Merged
merged 1 commit into from
Mar 23, 2019
Merged

Conversation

varjolintu
Copy link
Member

Fix for clearing the credentials when locking the screen.

Document visibility is hidden when the screen is locked. That kind of situation was not handled in the extension. The database hashes are updated only when the current document/page is visible. Now, when the document is hidden, all credentials are cleared just in case.

Fixes #357.

@droidmonkey
Copy link
Member

droidmonkey commented Jan 3, 2019

This did not work for me. I went to a page that had credentials, they were loaded into the drop-down selection. I locked my computer and unlocked. When I returned KPXC was locked and the browser icon showed the locked icon, but the credentials were still loaded.

Why not call the clear credentials function when the icon is changed to the lock symbol?

P.S. - I am on Chrome / Win10

@varjolintu
Copy link
Member Author

@droidmonkey Fixed. Check if it happens anymore.

@varjolintu varjolintu modified the milestones: Next, 1.3.3 Feb 1, 2019
@varjolintu varjolintu mentioned this pull request Feb 2, 2019
@whisdol
Copy link

whisdol commented Feb 2, 2019

While testing this (merged into PR #387), I ran into the following scenario (FF65, Windows 10):

  1. Open Firefox and a website with frames
  2. Open KeePassXC
  3. Click reconnect
  4. Click into the username field, credentials are suggested in the autocomplete-dialog. They are not listed in the extension menu.
  5. Close KeePassXC
  6. Lock screen
  7. Unlock screen
  8. Click into login field.

In my tries, the credentials were not cleared and still suggested in the autocomplete-dialog.

On a website without frames, the credentials were cleared after step 5.

@varjolintu
Copy link
Member Author

@whisdol Thanks! I'll check what causes this.

@whisdol
Copy link

whisdol commented Feb 4, 2019

This fix works for me, credentials are now (also) cleared after closing KeePassXC.

@varjolintu varjolintu merged commit 0e80a35 into develop Mar 23, 2019
@varjolintu varjolintu deleted the screen_lock_fix branch March 23, 2019 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants