ci: fail lint on warning (shapeshift#168)

keepkey · Oct 27, 2021 · 5688394 · 5688394
1 parent bbbbf95
commit 5688394
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -12,7 +12,7 @@
     "build": "lerna run build --include-dependencies",
     "clean": "rimraf node_modules dist packages/**/dist",
     "dev": "lerna run dev --stream --parallel",
-    "lint": "eslint --cache .",
+    "lint": "eslint --cache --max-warnings=0 .",
     "link-packages": "node scripts/linkPackages.js link",
     "unlink-packages": "node scripts/linkPackages.js unlink",
     "test": "jest",

diff --git a/packages/chain-adapters/src/bitcoin/BitcoinChainAdapter.test.ts b/packages/chain-adapters/src/bitcoin/BitcoinChainAdapter.test.ts
@@ -379,7 +379,7 @@ describe('BitcoinChainAdapter', () => {
     })
   })
 
-  describe.skip('getFeeData', () => {
+  describe('getFeeData', () => {
     it('should return current BTC network fees', async () => {
       const adapter = new bitcoin.ChainAdapter(args)
 

diff --git a/packages/swapper/src/swappercli.ts b/packages/swapper/src/swappercli.ts
@@ -45,7 +45,7 @@ const getWallet = async (): Promise<NativeHDWallet> => {
 }
 
 const main = async (): Promise<void> => {
-  const [_, __, ...args] = process.argv
+  const [, , ...args] = process.argv
   const [sellSymbol, buySymbol, sellAmount] = args
 
   console.info(`sellSymbol: sell ${sellAmount} of ${sellSymbol} to ${buySymbol}`)

diff --git a/packages/swapper/src/swappers/zrx/approvalNeeded/approvalNeeded.ts b/packages/swapper/src/swappers/zrx/approvalNeeded/approvalNeeded.ts
@@ -3,7 +3,6 @@ import { AxiosResponse } from 'axios'
 import {
   ApprovalNeededInput,
   ApprovalNeededOutput,
-  BIP32Params,
   ChainTypes,
   QuoteResponse,
   SwapperType