Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Addon TTL to 1-hour and reset status per checksum change #86

Merged
merged 8 commits into from
Jun 9, 2021
Merged

Increase Addon TTL to 1-hour and reset status per checksum change #86

merged 8 commits into from
Jun 9, 2021

Conversation

kevdowney
Copy link
Collaborator

Fixes Addon reconciliation by changing the following:

  • .status.startime is now required
  • All status is reset whenever checksum changes
  • Status updates are now gated per addon, prevents conflicts
  • TTL is increased to 1 Hour

@kevdowney kevdowney requested a review from a team as a code owner June 9, 2021 16:33
@kevdowney kevdowney changed the title Fix addon reconcile flow Fix addon reconcile flow by resetting status per checksum Jun 9, 2021
@kevdowney kevdowney changed the title Fix addon reconcile flow by resetting status per checksum Increase ttl and reset status per checksum change Jun 9, 2021
@kevdowney kevdowney changed the title Increase ttl and reset status per checksum change Increase Addon TTL to 1-hour and reset status per checksum change Jun 9, 2021
@codecov
Copy link

codecov bot commented Jun 9, 2021 •
edited
Loading

Codecov Report

Merging #86 (58ba0ce) into master (288676b) will increase coverage by 0.89%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   45.73%   46.63%   +0.89%     
==========================================
  Files           9        9              
  Lines        1126     1128       +2     
==========================================
+ Hits          515      526      +11     
+ Misses        540      531       -9     
  Partials       71       71
Impacted Files Coverage Δ
api/v1alpha1/addon_types.go 50.00% <ø> (ø)
controllers/addon_controller.go 45.35% <85.71%> (+3.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 288676b...58ba0ce. Read the comment docs.

@kevdowney kevdowney merged commit 70e350e into keikoproj:master Jun 9, 2021
@kevdowney kevdowney deleted the fix-addon-reconcile-flow branch June 9, 2021 16:57
@kevdowney kevdowney mentioned this pull request Jun 9, 2021
Merged
ccfishk pushed a commit that referenced this pull request Feb 7, 2022
@kevdowney
Increase Addon TTL to 1-hour and reset status per checksum change (#86)
b044414 
* Make starttime mandatory
* Add a sync.WaitGroup for updating status per addon
* Enhance logging
* Reset status whenever checksum changes
* Change TTL to 1 hour
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kevdowney