Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember-weakmap to the latest version 🚀 #127

Merged
merged 1 commit into from
Sep 8, 2017
Merged

Update ember-weakmap to the latest version 🚀 #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions addon/create-class-computed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import EmberObject, { computed, observer, get, setProperties } from '@ember/obje
import Component from '@ember/component';
import { on } from '@ember/object/evented';
// import { getOwner } from '@ember/application';
import WeakMap from 'ember-weakmap';
import getValue from './get-value';
import { collapseKeysWithMap } from './collapse-keys';
import flattenKeys from './flatten-keys';
Expand All @@ -12,7 +11,11 @@ import {
ARRAY_LENGTH
} from './-constants';

const { defineProperty, meta } = Ember;
const {
WeakMap,
defineProperty,
meta
} = Ember;

const PROPERTIES = new WeakMap();

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"ember-cli-babel": "^6.6.0",
"ember-cli-string-utils": "^1.1.0",
"ember-cli-test-info": "^1.0.0",
"ember-weakmap": "^2.0.0"
"ember-weakmap": "^3.0.0"
},
"devDependencies": {
"ember-cli": "~2.14.2",
Expand Down
4 changes: 3 additions & 1 deletion tests/integration/create-class-computed-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import Ember from 'ember';
import createClassComputed from 'ember-macro-helpers/create-class-computed';
import normalizeArrayKey from 'ember-macro-helpers/normalize-array-key';
import computed from 'ember-macro-helpers/computed';
Expand All @@ -6,9 +7,10 @@ import { module, test } from 'qunit';
import EmberObject from '@ember/object';
import { A as emberA } from '@ember/array';
import compute from 'ember-macro-test-helpers/compute';
import WeakMap from 'ember-weakmap';
import destroy from '../helpers/destroy';

const { WeakMap } = Ember;

let PROPERTIES;
let filterBy;

Expand Down