Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Crystal 0.35.0 #570

Merged
merged 4 commits into from
Jun 10, 2020
Merged

Conversation

bcardiff
Copy link
Contributor

@bcardiff bcardiff commented Jun 9, 2020

These are some of the changes to upgrade to Crystal 0.35 without warnings.

FYI ameba is also waiting on some changes to be released to avoid warnings.

@bararchy
Copy link

@straight-shoota do you have write access to approve this PR? I don't know when @sdogruyol will have time for that.

Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @bcardiff 🙏

@jgillich
Copy link

Can we get a new release, please? :)

@petr-fischer
Copy link

Hello, will be available proper Kemal release compaitble with Crystal 0.35.x?

@imkgautam
Copy link

Hello, will be available proper Kemal release compaitble with Crystal 0.35.x?

Not now

@ghost
Copy link

ghost commented Sep 8, 2020

Hello, will be available proper Kemal release compaitble with Crystal 0.35.x?

Apparently not yet, but until then I created a fork sugarfi/kemal where version 0.26.2 should be compatible with Crystal 0.35.1.

makenowjust pushed a commit to crystal-jp/introducing-crystal that referenced this pull request Mar 14, 2021
* Especially `kemal-sample` needs to update dependencies to include kemalcr/kemal#570
* If you faced an error as below
 `ld: library not found for -lssl (this usually means you need to install the development package for libssl)`
  on Mac OS X, `export PKG_CONFIG_PATH=/usr/local/opt/openssl/lib/pkgconfig` will help you
  ref: crystal-lang/crystal#6875 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants