This repository has been archived by the owner on Oct 2, 2018. It is now read-only.
First part for Indexes (+ other Issues) #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* backend allows different hands * single-argument ini-configs
* rules can play add-power cards * testing api * Fe limit (#3) * api passes limit * cards retrieved from rows * single-argument ini-config * useless spaces * new test
|
...I think I messed up, but don't know where :'( |
kenan-rhoton
reviewed
Apr 6, 2018
backend/src/rules/create_game.clj
Outdated
| })) | ||
| [hand player] | ||
| { | ||
| :hand (loop [final-hand [] |
There was a problem hiding this comment.
I would replace the loop with this:
(mapv (fn [card id] (assoc card :id id)) hand (iterate inc 1000))There was a problem hiding this comment.
I don't think this does the same as the loop.
The loop is supposed to use indexes begining with 0 for player 0, and beginning with 1000 for player 1.
EDIT: Ok, only needed to change it for (iterate inc (* player 1000))
kenan-rhoton
suggested changes
Apr 6, 2018
kenan-rhoton
approved these changes
Apr 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #75, resolves #87 and is the first part for #55.
I merged the pull-request #103 and #105 into this for being able to work on #55.