This repository has been archived by the owner on Oct 2, 2018. It is now read-only.
Tests for api #129
Merged
Tests for api #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenan-rhoton
previously requested changes
Aug 31, 2018
backend/src/rules/count_cards.clj
Outdated
| @@ -1,7 +1,7 @@ | |||
| (ns rules.count-cards) | |||
|
|
|||
| (defn count-cards | |||
| "Count all cards that has keys as in condition an sums their summand" | |||
| "Count all cards that has keys as in condition (or sums their summand)" | |||
backend/test/api/base_test.clj
Outdated
| (:require [expectations.clojure.test :refer :all] | ||
| [clojure.test :as ctest] | ||
| [mocking :as mocking] | ||
| [api.base :as base] | ||
| [configs.hands :as hands] |
There was a problem hiding this comment.
Wait, this is used below, right? as hands/default-hand?
There was a problem hiding this comment.
Probably that's why it fails the tests (sorry, couldn't run them).
Still... I don't understand how I removed this line... Thanks.
kenan-rhoton
approved these changes
Sep 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joining
api/base.cljtests and removing already considered tests.